[PATCH u-boot v2019.04-aspeed-openbmc v2 1/3] aspeed/sdram: Use device tree to configure ECC

[Joel Stanley]

On Wed, 21 Sept 2022 at 06:10, Andrew Jeffery <andrew at aj.id.au> wrote:

> >  #ifdef CONFIG_ASPEED_ECC
> > -     ast2500_sdrammc_ecc_enable(info);
> > +     if (dev_read_bool(dev, "aspeed,ecc-enabled")) {
> > +             u32 ecc_size;
> > +
> > +             ecc_size = dev_read_u32_default(dev, "aspeed,ecc-size-mb", 0);
> > +             ast2500_sdrammc_ecc_enable(priv, ecc_size);
>
> The code you deleted passes `info` to ast2500_sdrammc_ecc_enable() as
> the first argument but you're passing `priv` here. Do they alias?
>
> Ah, actually, I think you copied the code from sdram_ast2600.c into
> sdram_ast2500.c. I suspect this might not compile?

Well spotted. I was build testing, but it seems it wasn't building
what I thought it was.

Cheers,

Joel