[PATCH u-boot v2019.04-aspeed-openbmc 1/2] aspeed/sdram: Use device tree to configure ECC

[Joel Stanley]

On Mon, 29 Aug 2022 at 18:31, Adriana Kobylak <anoo at linux.ibm.com> wrote:
> > #ifdef CONFIG_ASPEED_ECC
> > -static void ast2600_sdrammc_ecc_enable(struct dram_info *info)
> > +static void ast2600_sdrammc_ecc_enable(struct dram_info *info, u32 conf_size_mb)
> > {
> >       struct ast2600_sdrammc_regs *regs = info->regs;
> >       size_t conf_size;
> >       u32 reg;
> >
> > -     conf_size = CONFIG_ASPEED_ECC_SIZE * SDRAM_SIZE_1MB;
> > +     conf_size = conf_size_mb * SDRAM_SIZE_1MB;
> >       if (conf_size > info->info.size) {
> >               printf("warning: ECC configured %dMB but actual size is %dMB\n",
> > -                    CONFIG_ASPEED_ECC_SIZE,
> > +                    conf_size,
>
> This should be “conf_size_mb,”?

Thanks, I've fixed that when applying.

>
> >                      info->info.size / SDRAM_SIZE_1MB);
> >               conf_size = info->info.size;
> >       } else if (conf_size == 0) {
> > @@ -989,8 +989,14 @@ L_ast2600_sdramphy_train:
> > #endif