[PATCH v2 02/36] gpiolib: cdev: Add missed header(s)

Andy Shevchenko andriy.shevchenko at linux.intel.com
Thu Oct 13 00:30:05 AEDT 2022

On Tue, Oct 11, 2022 at 08:01:27AM +0800, Kent Gibson wrote:
> On Mon, Oct 10, 2022 at 11:14:18PM +0300, Andy Shevchenko wrote:


> > -#include <linux/gpio.h>
> >  #include <linux/gpio/driver.h>
> > +#include <linux/gpio.h>

> But moving the gpio subsystem header after the gpio/driver is not
> alphabetical ('.' precedes '/') and it read better and made more sense
> to me the way it was.

Okay, I will move it back.


> > +#include <linux/seq_file.h>
> I wasn't aware that we use anything from seq_file.
> What am I missing?

Eventually I can answer to your question: the commit 0ae3109a8391
("gpiolib: cdev: add fdinfo output for line request file descriptors")
is what you are missing.

That said, we need this patch.

With Best Regards,
Andy Shevchenko

More information about the openbmc mailing list