[PATCH linux dev-6.0] arm: dts: aspeed: ibm-power9-dual: Update OCC nodes

Joel Stanley joel at jms.id.au
Thu Nov 17 14:13:26 AEDT 2022


On Wed, 16 Nov 2022 at 16:57, Eddie James <eajames at linux.ibm.com> wrote:
>
> Set the ibm,no-poll-on-init property for the OCCs.

Is this required to make them probe?

Previously they worked (it would attempt to read form the host and
fail, but the driver would probe). Do we need to fix the driver, or do
we need to fix all of the device trees (vesnin, palmetto, tacoma)?

>
> Signed-off-by: Eddie James <eajames at linux.ibm.com>
> ---
>  arch/arm/boot/dts/ibm-power9-dual.dtsi | 23 ++++++++++++-----------
>  1 file changed, 12 insertions(+), 11 deletions(-)
>
> diff --git a/arch/arm/boot/dts/ibm-power9-dual.dtsi b/arch/arm/boot/dts/ibm-power9-dual.dtsi
> index a0fa65b44b0f..916041e6e00c 100644
> --- a/arch/arm/boot/dts/ibm-power9-dual.dtsi
> +++ b/arch/arm/boot/dts/ibm-power9-dual.dtsi
> @@ -86,8 +86,13 @@ sbefifo at 2400 {
>                         #address-cells = <1>;
>                         #size-cells = <0>;
>
> -                       fsi_occ0: occ at 1 {
> +                       fsi_occ0: occ {
>                                 compatible = "ibm,p9-occ";
> +
> +                               occ-hwmon {
> +                                       compatible = "ibm,p9-occ-hwmon";
> +                                       ibm,no-poll-on-init;
> +                               };
>                         };
>                 };
>
> @@ -187,8 +192,13 @@ sbefifo at 2400 {
>                         #address-cells = <1>;
>                         #size-cells = <0>;
>
> -                       fsi_occ1: occ at 2 {
> +                       fsi_occ1: occ {
>                                 compatible = "ibm,p9-occ";
> +
> +                               occ-hwmon {
> +                                       compatible = "ibm,p9-occ-hwmon";
> +                                       ibm,no-poll-on-init;
> +                               };
>                         };
>                 };
>
> @@ -203,15 +213,6 @@ fsi_hub1: hub at 3400 {
>         };
>  };
>
> -/* Legacy OCC numbering (to get rid of when userspace is fixed) */
> -&fsi_occ0 {
> -       reg = <1>;
> -};
> -
> -&fsi_occ1 {
> -       reg = <2>;
> -};
> -
>  / {
>         aliases {
>                 i2c100 = &cfam0_i2c0;
> --
> 2.31.1
>


More information about the openbmc mailing list