[PATCH v3 0/3] Add ASPEED AST2600 I2C new controller driver

Ryan Chen ryan_chen at aspeedtech.com
Fri May 20 13:15:59 AEST 2022


> -----Original Message-----
> From: Peter Delevoryas <pdel at fb.com>
> Sent: Friday, May 20, 2022 11:02 AM
> Cc: Joel Stanley <joel at jms.id.au>; Andrew Jeffery <andrew at aj.id.au>; Philipp
> Zabel <p.zabel at pengutronix.de>; linux-arm-kernel at lists.infradead.org;
> linux-aspeed at lists.ozlabs.org; linux-kernel at vger.kernel.org; OpenBMC List
> <openbmc at lists.ozlabs.org>; BMC-SW <BMC-SW at aspeedtech.com>; Ryan
> Chen <ryan_chen at aspeedtech.com>; Peter Delevoryas <pdel at fb.com>
> Subject: Re: [PATCH v3 0/3] Add ASPEED AST2600 I2C new controller driver
> 
> 
> 
> > On May 19, 2022, at 7:46 PM, Ryan Chen <ryan_chen at aspeedtech.com>
> wrote:
> >
> > Hello,
> >
> >> -----Original Message-----
> >> From: Peter Delevoryas <pdel at fb.com>
> >> Sent: Friday, May 20, 2022 3:56 AM
> >> Cc: Joel Stanley <joel at jms.id.au>; Andrew Jeffery <andrew at aj.id.au>;
> >> Philipp Zabel <p.zabel at pengutronix.de>;
> >> linux-arm-kernel at lists.infradead.org;
> >> linux-aspeed at lists.ozlabs.org; linux-kernel at vger.kernel.org; OpenBMC
> >> List <openbmc at lists.ozlabs.org>; BMC-SW <BMC-SW at aspeedtech.com>;
> >> Peter Delevoryas <pdel at fb.com>; Ryan Chen
> <ryan_chen at aspeedtech.com>
> >> Subject: Re: [PATCH v3 0/3] Add ASPEED AST2600 I2C new controller
> >> driver
> >>
> >>
> >>
> >>> On May 15, 2022, at 11:48 PM, ryan_chen <ryan_chen at aspeedtech.com>
> >> wrote:
> >>>
> >>> This series add AST2600 i2c new register set driver. The i2c new
> >>> register set have new clock divider option for more flexiable generation.
> >>> And also have separate i2c master and slave register set for control.
> >>
> >> Hey Ryan, thanks for this work! This is a little bit off-topic, but
> >> are you or anyone else at Aspeed working on an equivalent QEMU patch
> >> series? Without it, I don’t think QEMU will work with this series
> >> right? I think QEMU only supports the old register set right now.
> >>
> > No, there are two submit in QEMU about i2c new register mode.
> > One is ASPEED submit :
> > https://patchwork.kernel.org/project/qemu-devel/list/?series=626028&ar
> > chive=both Another is GOOGLE :
> > https://patchwork.kernel.org/project/qemu-devel/list/?series=627706&ar
> > chive=both
> 
> Oh great, thanks. I just tried the Aspeed QEMU series and it worked for me
> with Zephyr, very helpful!
Thanks your feedback, it check ok, please let me know.

> 
> >
> >>
> >>>
> >>> v3:
> >>> -fix i2c global clock divide default value -remove i2c slave no used
> >>> dev_dbg info.
> >>>
> >>> v2:
> >>> -add i2c global ymal file commit
> >>> -rename file name from new to ast2600.
> >>> aspeed-i2c-new-global.c -> i2c-ast2600-global.c
> >>> aspeed-i2c-new-global.h -> i2c-ast2600-global.h i2c-new-aspeed.c ->
> >>> i2c-ast2600.c -rename all driver function name to ast2600
> >>>
> >>> ryan_chen (3):
> >>> dt-bindings: i2c-ast2600: Add bindings for AST2600 i2C global
> >>> register controller
> >>> dt-bindings: i2c-ast2600: Add bindings for AST2600 i2C driver
> >>> i2c:aspeed:support ast2600 i2c new register mode driver
> >>>
> >>> .../i2c/aspeed,i2c-ast2600-global.ymal | 44 +
> >>> .../bindings/i2c/aspeed,i2c-ast2600.ymal | 78 +
> >>> drivers/i2c/busses/Kconfig | 11 + drivers/i2c/busses/Makefile | 1 +
> >>> drivers/i2c/busses/i2c-ast2600-global.c | 94 +
> >>> drivers/i2c/busses/i2c-ast2600-global.h | 19 +
> >>> drivers/i2c/busses/i2c-ast2600.c | 1703
> >> +++++++++++++++++
> >>> 7 files changed, 1950 insertions(+)
> >>> create mode 100644
> >>> Documentation/devicetree/bindings/i2c/aspeed,i2c-ast2600-global.ymal
> >>> create mode 100644
> >>> Documentation/devicetree/bindings/i2c/aspeed,i2c-ast2600.ymal
> >>> create mode 100644 drivers/i2c/busses/i2c-ast2600-global.c
> >>> create mode 100644 drivers/i2c/busses/i2c-ast2600-global.h
> >>> create mode 100644 drivers/i2c/busses/i2c-ast2600.c
> >>>
> >>> --
> >>> 2.17.1



More information about the openbmc mailing list