[PATCH] ftgmac100: use bus name in mdio error messages

Joel Stanley joel at jms.id.au
Tue May 17 14:54:35 AEST 2022


On Tue, 17 May 2022 at 04:51, Zev Weiss <zev at bewilderbeest.net> wrote:
>
> On Mon, May 16, 2022 at 09:38:25PM PDT, Zev Weiss wrote:
> > Previously we'd been using a device name retrieved via
> > ftgmac100_data->phydev, but the mdio read/write functions may be
> > called before that member is initialized in ftgmac100_phy_init(),
> > leading to a NULL pointer dereference while printing the error message
> > issued if the mdio access fails.  We can instead use bus->name, which
> > is already available at that point.
> >
> > Signed-off-by: Zev Weiss <zev at bewilderbeest.net>
> > Fixes: 538e75d3fc54 ("net: ftgmac100: add MDIO bus and phylib support")
> > ---
> >  drivers/net/ftgmac100.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
>
> Sorry, forgot the subject-prefix tag on this one -- this is for u-boot
> v2019.04-aspeed-openbmc in case it wasn't clear.

Thanks, I figured that out :)

How do you reproduce this one?

I didn't realise we had downstream changes for this driver, we should
ask aspeed to submit their downstream changes to u-boot mainline.


More information about the openbmc mailing list