[PATCH 2/2] hw: aspeed: Init all UART's with serial devices

Peter Delevoryas pdel at fb.com
Mon May 16 08:55:28 AEST 2022



> On May 15, 2022, at 2:19 PM, Cédric Le Goater <clg at kaod.org> wrote:
> 
> [ ... ]
> 
>>> The problem is that it is breaking compatibility with previous QEMUs.
>> It is? We can still run things the old way too, I specifically
>> wrote this with the intention that it would support backwards
>> compatibility.
> 
> You are right. Let's start with your patchset. We can add the "uart"
> machine option when the need arises.
> 
> I have sent a small cleanup of aspeed_soc_get_irq() that should avoid
> the duplication of the serial init in the different SoC models. Please
> give it a try.
> 

Oh this is fantastic, thanks! I’ll gladly put the serial init code into
a function declared in aspeed_soc.h then.

> Thanks,
> 
> C.
> 



More information about the openbmc mailing list