[PATCH] pinctrl: nuvoton: wpcm450: off by one in wpcm450_gpio_register()

[Jonathan Neuschäfer]

On Fri, Mar 18, 2022 at 10:11:31AM +0300, Dan Carpenter wrote:
> The > WPCM450_NUM_BANKS should be >= or it leads to an out of bounds
> access on the next line.

True.

> Fixes: a1d1e0e3d80a ("pinctrl: nuvoton: Add driver for WPCM450")
> Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>
> ---

Reviewed-by: Jonathan Neuschäfer <j.neuschaefer at gmx.net>


Thanks,
Jonathan

>  drivers/pinctrl/nuvoton/pinctrl-wpcm450.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pinctrl/nuvoton/pinctrl-wpcm450.c b/drivers/pinctrl/nuvoton/pinctrl-wpcm450.c
> index 661aa963e3fc..164d7a6e7b5b 100644
> --- a/drivers/pinctrl/nuvoton/pinctrl-wpcm450.c
> +++ b/drivers/pinctrl/nuvoton/pinctrl-wpcm450.c
> @@ -1043,7 +1043,7 @@ static int wpcm450_gpio_register(struct platform_device *pdev,
>  		gpio = &pctrl->gpio_bank[reg];
>  		gpio->pctrl = pctrl;
>  
> -		if (reg > WPCM450_NUM_BANKS)
> +		if (reg >= WPCM450_NUM_BANKS)
>  			return dev_err_probe(dev, -EINVAL,
>  					     "GPIO index %d out of range!\n", reg);
>  
> -- 
> 2.20.1
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/openbmc/attachments/20220318/6d8ab474/attachment.sig>