Checking for network online

[Jiaqing Zhao]

On 2022-02-25 04:09, Patrick Williams wrote:
> On Wed, Feb 23, 2022 at 12:04:12PM -0800, Johnathan Mantey wrote:
>> On 2/23/22 09:44, Jiaqing Zhao wrote:
>>> On 2022-02-23 21:48, Patrick Williams wrote:
>>>> On Wed, Feb 23, 2022 at 10:09:19AM +0800, Jiaqing Zhao wrote:
> 
>> There may be openbmc powered servers that do use the distributed logging 
>> provided by rsyslogd. If there are then globally removing network-online 
>> from the rsyslog service file is undesirable. I consider the same to be 
>> true of assigning a default RequiredForOnline=false.
>>
>> Based on the above, it's my opinion this is a vendor based decision for 
>> how to configure rsyslog/systemd-networkd-wait-online.
> 
> I agree we shouldn't enable this globally, but that doesn't mean we can't add
> a simple PKGCONFIG that allows it to be enabled/disabled as needed.  That way
> we only have the single `PKGCONFIG:append` line in vendor layers and vendors
> that have a problem with it can leave it same as upstream.

I am also in favor of this solution, let the vendor decide whether rsyslog depends on network-online.target or not with the PKGCONFIG option.