[PATCH 2/2] ARM: dts: aspeed: Remove "spi-flash" compatible

Joel Stanley joel at jms.id.au
Thu Jun 16 22:35:30 AEST 2022


On Wed, 8 Jun 2022 at 06:19, Joel Stanley <joel at jms.id.au> wrote:
>
> On Wed, 8 Jun 2022 at 06:15, Cédric Le Goater <clg at kaod.org> wrote:
> >
> > The underlying SoC definitions use compatible "jedec,spi-nor", so does
> > the aspeed SPI driver, this to be in sync with Linux and the latest
> > U-Boot.
>
> > diff --git a/arch/arm/dts/ast2600-tacoma.dts b/arch/arm/dts/ast2600-tacoma.dts
> > index 67b3e3013c6b..a29e7e7fa23a 100755
> > --- a/arch/arm/dts/ast2600-tacoma.dts
> > +++ b/arch/arm/dts/ast2600-tacoma.dts
> > @@ -65,7 +65,6 @@
> >
> >         flash at 0 {
> >                 // TODO: what compatible strings should be here?
> > -               compatible = "spi-flash", "sst,w25q256";
>
> Thanks. I had a similar version that also removed these todos. I'll
> merge yours and remove the TODOs too.
>
> Reviewed-by: Joel Stanley <joel at jms.id.au>

I have applied these two, thanks.

>
>
> >                 status = "okay";
> >                 spi-max-frequency = <50000000>;
> >                 spi-tx-bus-width = <2>;


More information about the openbmc mailing list