[PATCH 15/34] iio: humidity: hts221_buffer: explicitly add proper header files

Jonathan Cameron jic23 at kernel.org
Sun Jun 12 00:22:22 AEST 2022

On Fri, 10 Jun 2022 16:47:16 +0200
Andy Shevchenko <andy.shevchenko at gmail.com> wrote:

> On Fri, Jun 10, 2022 at 10:47 AM Nuno Sá <nuno.sa at analog.com> wrote:
> >
> > Do not trust the fact that iio.h includes of.h which in turn includes
> > all the headers we are relying on.
> >
> > The ultimate goal is to actually drop of.h from iio.h.  
> ...
> >  #include <linux/irqreturn.h>
> >  #include <linux/regmap.h>
> >  #include <linux/bitfield.h>
> > +#include <linux/property.h>  
> Yes, I see, but you can make life easier if you try to squeeze to the
> most sorted part. I do not see full context, but here I would put it
> before regmap.h.
With full context it's clear the list is way off sorted, but meh
putting it above regmap probably reduces the follow up diff a tiny
bit and I doubt Nuno feels strongly about this so I went with
what Andy suggested as a tweak whilst applying.




More information about the openbmc mailing list