[PATCH v4] soc: nuvoton: Add SoC info driver for WPCM450

Arnd Bergmann arnd at arndb.de
Thu Jun 16 00:00:17 AEST 2022

On Thu, Jun 9, 2022 at 11:35 PM Jonathan Neuschäfer
<j.neuschaefer at gmx.net> wrote:
> Add a SoC information driver for Nuvoton WPCM450 SoCs. It provides
> information such as the SoC revision.
> Usage example:
>   # grep . /sys/devices/soc0/*
>   /sys/devices/soc0/family:Nuvoton NPCM
>   /sys/devices/soc0/revision:A3
>   /sys/devices/soc0/soc_id:WPCM450
> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer at gmx.net>
> Reviewed-by: Joel Stanley <joel at jms.id.au>
> Reviewed-by: Paul Menzel <pmenzel at molgen.mpg.de>

Looks good overall.

> +menuconfig WPCM450_SOC
> +       bool "Nuvoton WPCM450 SoC driver"
> +       default y if ARCH_WPCM450

It would be nice to make this a tristate option, as we generally
like to keep optional drivers out of the allmodconfig vmlinux file,
even if this is a tiny one.

Just add the trivial cleanup function and MODULE_LICENSE() etc tags.


More information about the openbmc mailing list