[PATCH u-boot v2019.04-aspeed-openbmc 4/4] config: aspeed: Enable NCSI support
joel at jms.id.au
Wed Jun 15 16:33:06 AEST 2022
On Wed, 15 Jun 2022 at 06:00, Cédric Le Goater <clg at kaod.org> wrote:
> On 6/15/22 07:58, Joel Stanley wrote:
> > On Fri, 10 Jun 2022 at 09:31, Cédric Le Goater <clg at kaod.org> wrote:
> >> On 6/10/22 10:00, Joel Stanley wrote:
> >>> Now that NCSI can be enabled without breaking non-NCSI systems, enable
> >>> it in all defconfigs.
> >>> Signed-off-by: Joel Stanley <joel at jms.id.au>
> >> You should add :
> >> CONFIG_CMD_NCSI=y
> > Was this required, or just something that helps for testing?
> It helped for 'ping' if I remember well. Without it, it didn't
> work (on QEMU).
I see why. In net/net.c:
If CMD_NCSI is not enabled we never get a chance to probe the packages
(unless a NCSI packet happens to be received).
I think we should do this, so it works without the command, but I'm
not sure if it's the correct fix:
@@ -539,7 +539,7 @@ restart:
FWIW, the intent was that ncsi would work without the command:
More information about the openbmc