[PATCH v2] pinctrl: nuvoton: wpcm450: Convert irqchip to IRQCHIP_IMMUTABLE

Jonathan Neuschäfer j.neuschaefer at gmx.net
Mon Jun 13 19:44:42 AEST 2022


On Fri, Jun 10, 2022 at 02:07:55PM +0200, Andy Shevchenko wrote:
> On Fri, Jun 10, 2022 at 2:24 AM Jonathan Neuschäfer
> <j.neuschaefer at gmx.net> wrote:
> >
> > Commit 6c846d026d490 ("gpio: Don't fiddle with irqchips marked as
> > immutable") added a warning for irqchips that are not marked with
> > IRQCHIP_IMMUTABLE.
> >
> > Convert the pinctrl-wpcm450 driver to an immutable irqchip.
> 
> ...
> 
> > +       gpiochip_disable_irq(gc, d->hwirq);
> 
> > +       gpiochip_enable_irq(gc, d->hwirq);
> 
> Can you use the helper (*) as stated in the documentation?
> 
> *) irqd_to_hwirq(d)

Ah, oops. I'll fix it.


Thanks,
Jonathan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/openbmc/attachments/20220613/c8dd9042/attachment.sig>


More information about the openbmc mailing list