[PATCH u-boot v2019.04-aspeed-openbmc] ARM: dts: Aspeed: remove unnecessary i2c pinctrl

Joel Stanley joel at jms.id.au
Wed Jun 8 16:43:16 AEST 2022


On Wed, 8 Jun 2022 at 06:42, Jae Hyun Yoo <quic_jaehyoo at quicinc.com> wrote:
>
> Remove unnecessary i2c pinctrl from machine dts files to make them use
> default setting in ast2600.dtsi.
>
> Reported-by: Joel Stanley <joel at jms.id.au>
> Signed-off-by: Jae Hyun Yoo <quic_jaehyoo at quicinc.com>

Reviewed-by: Joel Stanley <joel at jms.id.au>

Thanks Jae.

> ---
>  arch/arm/dts/ast2600-bletchley.dts | 15 ---------------
>  arch/arm/dts/ast2600-evb.dts       | 15 ---------------
>  arch/arm/dts/ast2600-intel.dts     | 15 ---------------
>  arch/arm/dts/ast2600-ncsi.dts      | 15 ---------------
>  arch/arm/dts/ast2600-pfr.dts       | 15 ---------------
>  arch/arm/dts/ast2600-s6q.dts       | 26 --------------------------
>  arch/arm/dts/ast2600-slt.dts       | 15 ---------------
>  arch/arm/dts/ast2600a0-evb.dts     | 15 ---------------
>  arch/arm/dts/ast2600a1-evb.dts     | 15 ---------------
>  9 files changed, 146 deletions(-)
>
> diff --git a/arch/arm/dts/ast2600-bletchley.dts b/arch/arm/dts/ast2600-bletchley.dts
> index 57ca845b94a7..8067863de880 100644
> --- a/arch/arm/dts/ast2600-bletchley.dts
> +++ b/arch/arm/dts/ast2600-bletchley.dts
> @@ -170,37 +170,22 @@
>
>  &i2c4 {
>         status = "okay";
> -
> -       pinctrl-names = "default";
> -       pinctrl-0 = <&pinctrl_i2c5_default>;
>  };
>
>  &i2c5 {
>         status = "okay";
> -
> -       pinctrl-names = "default";
> -       pinctrl-0 = <&pinctrl_i2c6_default>;
>  };
>
>  &i2c6 {
>         status = "okay";
> -
> -       pinctrl-names = "default";
> -       pinctrl-0 = <&pinctrl_i2c7_default>;
>  };
>
>  &i2c7 {
>         status = "okay";
> -
> -       pinctrl-names = "default";
> -       pinctrl-0 = <&pinctrl_i2c8_default>;
>  };
>
>  &i2c8 {
>         status = "okay";
> -
> -       pinctrl-names = "default";
> -       pinctrl-0 = <&pinctrl_i2c9_default>;
>  };
>
>  &scu {
> diff --git a/arch/arm/dts/ast2600-evb.dts b/arch/arm/dts/ast2600-evb.dts
> index 515afa83af69..ad0bd4671917 100644
> --- a/arch/arm/dts/ast2600-evb.dts
> +++ b/arch/arm/dts/ast2600-evb.dts
> @@ -243,37 +243,22 @@
>
>  &i2c4 {
>         status = "okay";
> -
> -       pinctrl-names = "default";
> -       pinctrl-0 = <&pinctrl_i2c5_default>;
>  };
>
>  &i2c5 {
>         status = "okay";
> -
> -       pinctrl-names = "default";
> -       pinctrl-0 = <&pinctrl_i2c6_default>;
>  };
>
>  &i2c6 {
>         status = "okay";
> -
> -       pinctrl-names = "default";
> -       pinctrl-0 = <&pinctrl_i2c7_default>;
>  };
>
>  &i2c7 {
>         status = "okay";
> -
> -       pinctrl-names = "default";
> -       pinctrl-0 = <&pinctrl_i2c8_default>;
>  };
>
>  &i2c8 {
>         status = "okay";
> -
> -       pinctrl-names = "default";
> -       pinctrl-0 = <&pinctrl_i2c9_default>;
>  };
>
>  &pcie_phy1 {
> diff --git a/arch/arm/dts/ast2600-intel.dts b/arch/arm/dts/ast2600-intel.dts
> index 19d19f6ef52a..4b5a90b09223 100644
> --- a/arch/arm/dts/ast2600-intel.dts
> +++ b/arch/arm/dts/ast2600-intel.dts
> @@ -244,37 +244,22 @@
>
>  &i2c4 {
>         status = "okay";
> -
> -       pinctrl-names = "default";
> -       pinctrl-0 = <&pinctrl_i2c5_default>;
>  };
>
>  &i2c5 {
>         status = "okay";
> -
> -       pinctrl-names = "default";
> -       pinctrl-0 = <&pinctrl_i2c6_default>;
>  };
>
>  &i2c6 {
>         status = "okay";
> -
> -       pinctrl-names = "default";
> -       pinctrl-0 = <&pinctrl_i2c7_default>;
>  };
>
>  &i2c7 {
>         status = "okay";
> -
> -       pinctrl-names = "default";
> -       pinctrl-0 = <&pinctrl_i2c8_default>;
>  };
>
>  &i2c8 {
>         status = "okay";
> -
> -       pinctrl-names = "default";
> -       pinctrl-0 = <&pinctrl_i2c9_default>;
>  };
>
>  #if 0
> diff --git a/arch/arm/dts/ast2600-ncsi.dts b/arch/arm/dts/ast2600-ncsi.dts
> index dbe888a945e3..20ef7d7b9fb5 100644
> --- a/arch/arm/dts/ast2600-ncsi.dts
> +++ b/arch/arm/dts/ast2600-ncsi.dts
> @@ -245,37 +245,22 @@
>
>  &i2c4 {
>         status = "okay";
> -
> -       pinctrl-names = "default";
> -       pinctrl-0 = <&pinctrl_i2c5_default>;
>  };
>
>  &i2c5 {
>         status = "okay";
> -
> -       pinctrl-names = "default";
> -       pinctrl-0 = <&pinctrl_i2c6_default>;
>  };
>
>  &i2c6 {
>         status = "okay";
> -
> -       pinctrl-names = "default";
> -       pinctrl-0 = <&pinctrl_i2c7_default>;
>  };
>
>  &i2c7 {
>         status = "okay";
> -
> -       pinctrl-names = "default";
> -       pinctrl-0 = <&pinctrl_i2c8_default>;
>  };
>
>  &i2c8 {
>         status = "okay";
> -
> -       pinctrl-names = "default";
> -       pinctrl-0 = <&pinctrl_i2c9_default>;
>  };
>
>  #if 0
> diff --git a/arch/arm/dts/ast2600-pfr.dts b/arch/arm/dts/ast2600-pfr.dts
> index 8596207f5463..16bb84997a63 100644
> --- a/arch/arm/dts/ast2600-pfr.dts
> +++ b/arch/arm/dts/ast2600-pfr.dts
> @@ -247,37 +247,22 @@
>
>  &i2c4 {
>         status = "okay";
> -
> -       pinctrl-names = "default";
> -       pinctrl-0 = <&pinctrl_i2c5_default>;
>  };
>
>  &i2c5 {
>         status = "okay";
> -
> -       pinctrl-names = "default";
> -       pinctrl-0 = <&pinctrl_i2c6_default>;
>  };
>
>  &i2c6 {
>         status = "okay";
> -
> -       pinctrl-names = "default";
> -       pinctrl-0 = <&pinctrl_i2c7_default>;
>  };
>
>  &i2c7 {
>         status = "okay";
> -
> -       pinctrl-names = "default";
> -       pinctrl-0 = <&pinctrl_i2c8_default>;
>  };
>
>  &i2c8 {
>         status = "okay";
> -
> -       pinctrl-names = "default";
> -       pinctrl-0 = <&pinctrl_i2c9_default>;
>  };
>
>
> diff --git a/arch/arm/dts/ast2600-s6q.dts b/arch/arm/dts/ast2600-s6q.dts
> index 52b620d3b4fe..59fec60936dd 100644
> --- a/arch/arm/dts/ast2600-s6q.dts
> +++ b/arch/arm/dts/ast2600-s6q.dts
> @@ -118,80 +118,54 @@
>
>  &i2c0 {
>         status = "okay";
> -       pinctrl-names = "default";
> -       pinctrl-0 = <&pinctrl_i2c1_default>;
>  };
>
>  &i2c1 {
>         status = "okay";
> -       pinctrl-names = "default";
> -       pinctrl-0 = <&pinctrl_i2c2_default>;
>  };
>
>  &i2c2 {
>         status = "okay";
> -       pinctrl-names = "default";
> -       pinctrl-0 = <&pinctrl_i2c3_default>;
>  };
>
>  &i2c3 {
>         status = "okay";
> -       pinctrl-names = "default";
> -       pinctrl-0 = <&pinctrl_i2c4_default>;
>  };
>
>  &i2c4 {
>         status = "okay";
> -       pinctrl-names = "default";
> -       pinctrl-0 = <&pinctrl_i2c5_default>;
>  };
>
>  &i2c5 {
>         status = "okay";
> -       pinctrl-names = "default";
> -       pinctrl-0 = <&pinctrl_i2c6_default>;
>  };
>
>  &i2c6 {
>         status = "okay";
> -       pinctrl-names = "default";
> -       pinctrl-0 = <&pinctrl_i2c7_default>;
>  };
>
>  &i2c7 {
>         status = "okay";
> -       pinctrl-names = "default";
> -       pinctrl-0 = <&pinctrl_i2c8_default>;
>  };
>
>  &i2c8 {
>         status = "okay";
> -       pinctrl-names = "default";
> -       pinctrl-0 = <&pinctrl_i2c9_default>;
>  };
>
>  &i2c9 {
>         status = "okay";
> -       pinctrl-names = "default";
> -       pinctrl-0 = <&pinctrl_i2c10_default>;
>  };
>
>  &i2c11 {
>         status = "okay";
> -       pinctrl-names = "default";
> -       pinctrl-0 = <&pinctrl_i2c12_default>;
>  };
>
>  &i2c14 {
>         status = "okay";
> -       pinctrl-names = "default";
> -       pinctrl-0 = <&pinctrl_i2c15_default>;
>  };
>
>  &i2c15 {
>         status = "okay";
> -       pinctrl-names = "default";
> -       pinctrl-0 = <&pinctrl_i2c16_default>;
>  };
>
>  &display_port {
> diff --git a/arch/arm/dts/ast2600-slt.dts b/arch/arm/dts/ast2600-slt.dts
> index 93c5d86ce379..9935b9c9a597 100644
> --- a/arch/arm/dts/ast2600-slt.dts
> +++ b/arch/arm/dts/ast2600-slt.dts
> @@ -241,37 +241,22 @@
>
>  &i2c4 {
>         status = "okay";
> -
> -       pinctrl-names = "default";
> -       pinctrl-0 = <&pinctrl_i2c5_default>;
>  };
>
>  &i2c5 {
>         status = "okay";
> -
> -       pinctrl-names = "default";
> -       pinctrl-0 = <&pinctrl_i2c6_default>;
>  };
>
>  &i2c6 {
>         status = "okay";
> -
> -       pinctrl-names = "default";
> -       pinctrl-0 = <&pinctrl_i2c7_default>;
>  };
>
>  &i2c7 {
>         status = "okay";
> -
> -       pinctrl-names = "default";
> -       pinctrl-0 = <&pinctrl_i2c8_default>;
>  };
>
>  &i2c8 {
>         status = "okay";
> -
> -       pinctrl-names = "default";
> -       pinctrl-0 = <&pinctrl_i2c9_default>;
>  };
>
>
> diff --git a/arch/arm/dts/ast2600a0-evb.dts b/arch/arm/dts/ast2600a0-evb.dts
> index 859808a10d7a..0ef856644c95 100644
> --- a/arch/arm/dts/ast2600a0-evb.dts
> +++ b/arch/arm/dts/ast2600a0-evb.dts
> @@ -230,37 +230,22 @@
>
>  &i2c4 {
>         status = "okay";
> -
> -       pinctrl-names = "default";
> -       pinctrl-0 = <&pinctrl_i2c5_default>;
>  };
>
>  &i2c5 {
>         status = "okay";
> -
> -       pinctrl-names = "default";
> -       pinctrl-0 = <&pinctrl_i2c6_default>;
>  };
>
>  &i2c6 {
>         status = "okay";
> -
> -       pinctrl-names = "default";
> -       pinctrl-0 = <&pinctrl_i2c7_default>;
>  };
>
>  &i2c7 {
>         status = "okay";
> -
> -       pinctrl-names = "default";
> -       pinctrl-0 = <&pinctrl_i2c8_default>;
>  };
>
>  &i2c8 {
>         status = "okay";
> -
> -       pinctrl-names = "default";
> -       pinctrl-0 = <&pinctrl_i2c9_default>;
>  };
>
>
> diff --git a/arch/arm/dts/ast2600a1-evb.dts b/arch/arm/dts/ast2600a1-evb.dts
> index a5576a004f2d..61e24ecd7c38 100644
> --- a/arch/arm/dts/ast2600a1-evb.dts
> +++ b/arch/arm/dts/ast2600a1-evb.dts
> @@ -243,37 +243,22 @@
>
>  &i2c4 {
>         status = "okay";
> -
> -       pinctrl-names = "default";
> -       pinctrl-0 = <&pinctrl_i2c5_default>;
>  };
>
>  &i2c5 {
>         status = "okay";
> -
> -       pinctrl-names = "default";
> -       pinctrl-0 = <&pinctrl_i2c6_default>;
>  };
>
>  &i2c6 {
>         status = "okay";
> -
> -       pinctrl-names = "default";
> -       pinctrl-0 = <&pinctrl_i2c7_default>;
>  };
>
>  &i2c7 {
>         status = "okay";
> -
> -       pinctrl-names = "default";
> -       pinctrl-0 = <&pinctrl_i2c8_default>;
>  };
>
>  &i2c8 {
>         status = "okay";
> -
> -       pinctrl-names = "default";
> -       pinctrl-0 = <&pinctrl_i2c9_default>;
>  };
>
>
> --
> 2.25.1
>


More information about the openbmc mailing list