[PATCH] hwmon: (ucd9000) Add voltage monitor types
Jim Wright
wrightj at linux.ibm.com
Wed Jun 8 11:26:11 AEST 2022
On 6/7/2022 8:13 PM, Guenter Roeck wrote:
>
> I don't think it makes sense to claim VOUT support if the chip is
> configured to monitor input voltages. This should probably be something
> like
>
> ...
> > + case UCD9000_MON_VOLTAGE_AVS:
> > info->func[page] |= PMBUS_HAVE_VOUT
> > | PMBUS_HAVE_STATUS_VOUT;
> > break;
> case UCD9000_MON_INPUT_VOLTAGE:
> case UCD9000_MON_INPUT_VOLTAGE_AVS:
> info->func[page] |= PMBUS_HAVE_VIN;
> break;
>
> with appropriate mapping code to map the READ_VIN command for the
> affected pages to READ_VOUT. Question is if the limit registers on
> those pages are also reporting the limits using the vout limit
> commands; if so, those should be mapped as well.
>
> Guenter
Hi Guenter,
Thank you for the review. I'll drop adding the input voltage types and
resend the patch.
Jim Wright
More information about the openbmc
mailing list