[PATCH linux dev-5.15 2/2] hwmon: (occ) Lock mutex in shutdown to prevent race with occ_active

Eddie James eajames at linux.ibm.com
Wed Jun 8 05:01:18 AEST 2022

Unbinding the driver or removing the parent device at the same time
as using the OCC active sysfs file can cause the driver to unregister
the hwmon device twice. Prevent this by locking the occ mutex in the
shutdown function.

Signed-off-by: Eddie James <eajames at linux.ibm.com>
Link: https://lore.kernel.org/r/20220606185455.21126-1-eajames@linux.ibm.com
Signed-off-by: Guenter Roeck <linux at roeck-us.net>
 drivers/hwmon/occ/common.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/hwmon/occ/common.c b/drivers/hwmon/occ/common.c
index d78f4bebc718..ea070b91e5b9 100644
--- a/drivers/hwmon/occ/common.c
+++ b/drivers/hwmon/occ/common.c
@@ -1228,10 +1228,15 @@ EXPORT_SYMBOL_GPL(occ_setup);
 void occ_shutdown(struct occ *occ)
+	mutex_lock(&occ->lock);
 	if (occ->hwmon)
+	occ->hwmon = NULL;
+	mutex_unlock(&occ->lock);

More information about the openbmc mailing list