[PATCH u-boot v2019.04-aspeed-openbmc v2] ARM: dts: aspeed: add Qualcomm DC-SCM V1

[Jae Hyun Yoo]

Hi Joel,

On 6/6/2022 6:05 PM, Joel Stanley wrote:
> On Mon, 6 Jun 2022 at 13:56, Jae Hyun Yoo <quic_jaehyoo at quicinc.com> wrote:
>>
>> Ping
>>
>> On 5/19/2022 11:53 AM, Jae Hyun Yoo wrote:
>>> From: Graeme Gregory <quic_ggregory at quicinc.com>
>>>
>>> Add initial version of device tree for Qualcomm DC-SCM V1 BMC which is
>>> equipped with Aspeed AST2600 BMC SoC.
>>>
>>> Signed-off-by: Graeme Gregory <quic_ggregory at quicinc.com>
>>> Signed-off-by: Jae Hyun Yoo <quic_jaehyoo at quicinc.com>
>>> ---
>>> Changes in v2:
>>> * Changed vendor name from Nuvia to Qualcomm.
>>>
>>>    arch/arm/dts/Makefile                   |   1 +
>>>    arch/arm/dts/ast2600-qcom-dc-scm-v1.dts | 208 ++++++++++++++++++++++++
>>>    2 files changed, 209 insertions(+)
>>>    create mode 100644 arch/arm/dts/ast2600-qcom-dc-scm-v1.dts
>>>
>>> diff --git a/arch/arm/dts/ast2600-qcom-dc-scm-v1.dts b/arch/arm/dts/ast2600-qcom-dc-scm-v1.dts
>>> new file mode 100644
>>> index 000000000000..e966f739b708
>>> --- /dev/null
>>> +++ b/arch/arm/dts/ast2600-qcom-dc-scm-v1.dts

[...]

>>> +&i2c4 {
>>> +     status = "okay";
>>> +
>>> +     pinctrl-names = "default";
>>> +     pinctrl-0 = <&pinctrl_i2c5_default>;
> 
> All of the pinctrl properties are set in the dtsi as of f2b82fa4ba17
> ("arm: dts: ast2600: Add I2C pinctrl"), so you can drop these.

Yes, I checked that the commit f2b82fa4ba17 was recently merged.
I'll drop I2C pinctrl settings from this dts.

Thanks,
Jae

>>> +};
>>> +
>>> +&i2c5 {
>>> +     status = "okay";
>>> +
>>> +     pinctrl-names = "default";
>>> +     pinctrl-0 = <&pinctrl_i2c6_default>;
>>> +};
>>> +
>>> +&i2c6 {
>>> +     status = "okay";
>>> +
>>> +     pinctrl-names = "default";
>>> +     pinctrl-0 = <&pinctrl_i2c7_default>;
>>> +};
>>> +
>>> +&i2c7 {
>>> +     status = "okay";
>>> +
>>> +     pinctrl-names = "default";
>>> +     pinctrl-0 = <&pinctrl_i2c8_default>;
>>> +};
>>> +
>>> +&i2c8 {
>>> +     status = "okay";
>>> +
>>> +     pinctrl-names = "default";
>>> +     pinctrl-0 = <&pinctrl_i2c9_default>;
>>> +};
>>> +
>>> +&i2c9 {
>>> +     status = "okay";
>>> +
>>> +     pinctrl-names = "default";
>>> +     pinctrl-0 = <&pinctrl_i2c10_default>;
>>> +};
>>> +
>>> +&i2c10 {
>>> +     status = "okay";
>>> +
>>> +     pinctrl-names = "default";
>>> +     pinctrl-0 = <&pinctrl_i2c11_default>;
>>> +};
>>> +
>>> +&i2c12 {
>>> +     status = "okay";
>>> +
>>> +     pinctrl-names = "default";
>>> +     pinctrl-0 = <&pinctrl_i2c13_default>;
>>> +};
>>> +
>>> +&i2c13 {
>>> +     status = "okay";
>>> +
>>> +     pinctrl-names = "default";
>>> +     pinctrl-0 = <&pinctrl_i2c14_default>;
>>> +};
>>> +
>>> +&i2c14 {
>>> +     status = "okay";
>>> +
>>> +     pinctrl-names = "default";
>>> +     pinctrl-0 = <&pinctrl_i2c15_default>;
>>> +};
>>> +
>>> +&i2c15 {
>>> +     status = "okay";
>>> +
>>> +     pinctrl-names = "default";
>>> +     pinctrl-0 = <&pinctrl_i2c16_default>;
>>> +};
>>> +
>>> +&scu {
>>> +     mac0-clk-delay = <0x1d 0x1c
>>> +                       0x10 0x17
>>> +                       0x10 0x17>;
>>> +     mac1-clk-delay = <0x1d 0x10
>>> +                       0x10 0x10
>>> +                       0x10 0x10>;
>>> +     mac2-clk-delay = <0x0a 0x04
>>> +                       0x08 0x04
>>> +                       0x08 0x04>;
>>> +     mac3-clk-delay = <0x0a 0x04
>>> +                       0x08 0x04
>>> +                       0x08 0x04>;
>>> +};