[PATCH v2 2/2] spi: npcm-pspi: Add NPCM845 peripheral SPI support

Mark Brown broonie at kernel.org
Sat Jul 23 04:57:27 AEST 2022

On Fri, Jul 22, 2022 at 08:47:24PM +0200, Krzysztof Kozlowski wrote:
> On 22/07/2022 20:43, Mark Brown wrote:

> > ...with a fallback list required by the bindings so the driver actually
> > binds.  Note that bindings are currently not in YAML format so there'd
> > be even less enforcement of that than normal, and as they're currently
> > written the bindings don't require fallback.

> Yes, the bindings document should be rephrased but we were living like
> that for few years. :)

The binding document as it stands only has one compatible, there's no
existing problem with it other than the YAML conversion.  If we're
adding something new that requires a fallback we should be explicit
about that rather than have something that's actively misleading where
previously things were clear.  I don't mind if we add the compatible to
the driver or document the requirement for the fallback but we should do
one of the two.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/openbmc/attachments/20220722/0995e75f/attachment.sig>

More information about the openbmc mailing list