[PATCH v1 0/2] spi: npcm-pspi: add Arbel NPCM8XX and full duplex support

Tomer Maimon tmaimon77 at gmail.com
Fri Jul 22 00:35:58 AEST 2022

Hi Mark,

Thanks for your comment, next version I will make sure to send two
separate patches

On Thu, 21 Jul 2022 at 15:19, Mark Brown <broonie at kernel.org> wrote:
> On Thu, Jul 21, 2022 at 01:15:54PM +0300, Tomer Maimon wrote:
> > Tomer Maimon (2):
> >   spi: npcm-pspi: add full duplex support
> >   dt-binding: spi: npcm-pspi: Add npcm845 compatible
> It is not obvious why these are a series, they appear to be entirely
> orthogonal.  If there's no relationship between patches it's generally
> better to send them separately, that way problems with one patch won't
> hold up unrelated patches and reviewers aren't left wondering about why
> things are grouped.
> Please submit patches using subject lines reflecting the style for the
> subsystem, this makes it easier for people to identify relevant patches.
> Look at what existing commits in the area you're changing are doing and
> make sure your subject lines visually resemble what they're doing.
> There's no need to resubmit to fix this alone.

Best regards,


More information about the openbmc mailing list