[PATCH v2 2/2] iio: adc: npcm: Add NPCM8XX support

Andy Shevchenko andy.shevchenko at gmail.com
Wed Jul 13 20:14:39 AEST 2022

On Wed, Jul 13, 2022 at 9:07 AM Tomer Maimon <tmaimon77 at gmail.com> wrote:
> Adding ADC NPCM8XX support to NPCM ADC driver.
> ADC NPCM8XX uses a different resolution and voltage reference.
> As part of adding NPCM8XX support:
> - Add NPCM8XX specific compatible string.
> - Add data to handle architecture-specific ADC parameters.


> +       struct npcm_adc_info *data;

Can it be const?


> +       info->data = (struct npcm_adc_info *)device_get_match_data(dev);

...and hence no dropping qualifier is needed here, i.e. remove the casting.

With Best Regards,
Andy Shevchenko

More information about the openbmc mailing list