[PATCH v3 1/5] kunit: unify module and builtin suite definitions

Brendan Higgins brendanhiggins at google.com
Thu Jul 7 07:05:46 AEST 2022

On Sat, Jun 25, 2022 at 1:10 AM David Gow <davidgow at google.com> wrote:
> From: Jeremy Kerr <jk at codeconstruct.com.au>
> Currently, KUnit runs built-in tests and tests loaded from modules
> differently. For built-in tests, the kunit_test_suite{,s}() macro adds a
> list of suites in the .kunit_test_suites linker section. However, for
> kernel modules, a module_init() function is used to run the test suites.
> This causes problems if tests are included in a module which already
> defines module_init/exit_module functions, as they'll conflict with the
> kunit-provided ones.
> This change removes the kunit-defined module inits, and instead parses
> the kunit tests from their own section in the module. After module init,
> we call __kunit_test_suites_init() on the contents of that section,
> which prepares and runs the suite.
> This essentially unifies the module- and non-module kunit init formats.
> Tested-by: Maíra Canal <maira.canal at usp.br>
> Signed-off-by: Jeremy Kerr <jk at codeconstruct.com.au>
> Signed-off-by: Daniel Latypov <dlatypov at google.com>
> Signed-off-by: David Gow <davidgow at google.com>

Reviewed-by: Brendan Higgins <brendanhiggins at google.com>

More information about the openbmc mailing list