[PATCH u-boot v2019.04-aspeed-openbmc 3/3] board: ast2600_qualcomm: add env default

[Jae Hyun Yoo]

Hello Joel,

On 7/4/2022 11:52 PM, Joel Stanley wrote:
> On Thu, 30 Jun 2022 at 20:02, Jae Hyun Yoo <quic_jaehyoo at quicinc.com> wrote:
>>
>> Add env default to dc-scm-v1 board configuration.
>>
>> Signed-off-by: Jae Hyun Yoo <quic_jaehyoo at quicinc.com>
>> ---
>>   .../aspeed/ast2600_qualcomm/dc-scm-v1-u-boot-env-default.txt  | 4 ++++
>>   configs/ast2600_qcom_dc_scm_v1_defconfig                      | 2 ++
>>   2 files changed, 6 insertions(+)
>>   create mode 100644 board/aspeed/ast2600_qualcomm/dc-scm-v1-u-boot-env-default.txt
>>
>> diff --git a/board/aspeed/ast2600_qualcomm/dc-scm-v1-u-boot-env-default.txt b/board/aspeed/ast2600_qualcomm/dc-scm-v1-u-boot-env-default.txt
>> new file mode 100644
>> index 000000000000..9aebd38424ef
>> --- /dev/null
>> +++ b/board/aspeed/ast2600_qualcomm/dc-scm-v1-u-boot-env-default.txt
>> @@ -0,0 +1,4 @@
>> +bootargs=console=ttyS4,115200n8 root=/dev/ram rw
>> +bootcmd=bootm 20100000
>> +bootdelay=2
>> +loadaddr=0x83000000
> 
> This looks standard for a SPI boot. Do you really require it?

Ah, you are right. I realized that these are default for SPI boot and
can be configured by defconfig via CONFIG_BOOTARGS and
CONFIG_BOOTCOMMAND. I'll drop this change in v2.

Thanks,
Jae

>> diff --git a/configs/ast2600_qcom_dc_scm_v1_defconfig b/configs/ast2600_qcom_dc_scm_v1_defconfig
>> index 353882deed26..e602163e1caf 100644
>> --- a/configs/ast2600_qcom_dc_scm_v1_defconfig
>> +++ b/configs/ast2600_qcom_dc_scm_v1_defconfig
>> @@ -67,6 +67,8 @@ CONFIG_USE_ENV_SPI_CS=y
>>   CONFIG_ENV_SPI_CS=0
>>   CONFIG_USE_ENV_SPI_MAX_HZ=y
>>   CONFIG_ENV_SPI_MAX_HZ=100000000
>> +CONFIG_USE_DEFAULT_ENV_FILE=y
>> +CONFIG_DEFAULT_ENV_FILE="board/aspeed/ast2600_qualcomm/dc-scm-v1-u-boot-env-default.txt"
>>   CONFIG_NET_RANDOM_ETHADDR=y
>>   CONFIG_REGMAP=y
>>   CONFIG_SYSCON=y
>> --
>> 2.25.1
>>