Procedure for the send review on u-boot patch

Joel Stanley joel at jms.id.au
Wed Jan 19 14:06:46 AEDT 2022


On Tue, 18 Jan 2022 at 17:40, Patrick Williams <patrick at stwcx.xyz> wrote:
>
> On Mon, Jan 17, 2022 at 06:54:48AM +0000, Joel Stanley wrote:
> > On Fri, 14 Jan 2022 at 18:45, Patrick Williams <patrick at stwcx.xyz> wrote:
> > > On Thu, Jan 13, 2022 at 10:40:40PM +0000, Joel Stanley wrote:
> > > > I strongly recommend using the newer v2019.04 based branch for any new
> > > > system you're bringing up.
>
> I was under the mistaken assumption that the aspeed-sdk was not hosted and
> maintained by us.  In u-boot-common-aspeed-sdk_2019.04.inc I see:
>
> HOMEPAGE = "https://github.com/AspeedTech-BMC/u-boot"
>
> ... but ...
>
> SRC_URI = "git://git@github.com/openbmc/u-boot.git;nobranch=1;protocol=https"
>
> Should we align these to avoid any confusion?  I assume we should adjust the
> HOMEPAGE to point at our repository?

The upstream for our branch is that homepage URL. Ideally we would put
all of our patches into the SDK (I often send Aspeed pull requests to
do this), and un-fork the repository.

If you found the homepage URL confusing we could add a note to
explain, and change it. I'll leave it to you.


More information about the openbmc mailing list