Procedure for the send review on u-boot patch

Lei Yu yulei.sh at bytedance.com
Mon Jan 17 16:36:05 AEDT 2022


On Sat, Jan 15, 2022 at 2:46 AM Patrick Williams <patrick at stwcx.xyz> wrote:
>
> On Thu, Jan 13, 2022 at 10:40:40PM +0000, Joel Stanley wrote:
> > Hello,
> >
> > On Thu, 13 Jan 2022 at 08:52, logananth hcl <logananth13.hcl at gmail.com> wrote:
> > >
> > > Hai All,
> > >
> > > In openbmc/u-boot repo(branch - v2016.07-aspeed-openbmc)
> > > https://github.com/openbmc/u-boot/tree/v2016.07-aspeed-openbmc
> > >
> > > I want to send a review on this particular branch in u-boot through upstream.
> > > Is there any specific procedure to upstream it,
> > > kindly provide your suggestions.
> >
> > I strongly recommend using the newer v2019.04 based branch for any new
> > system you're bringing up.
>
> It doesn't seem like anyone is using this branch for any Aspeed system though.
>
> ```
> $ git grep "v2019.04"
> meta-aspeed/recipes-bsp/u-boot/u-boot-common-aspeed-sdk_2019.04.inc:PV = "v2019.04+git${SRCPV}"
> ```
>
> I think everyone doing AST2400/AST2500 work has been copying from existing
> systems and still pointing to the v2016.07 branch that we have working in the
> tree.
>

Doing `git grep u-boot-aspeed-sdk` and there are a few systems using
the new u-boot.

Just a note: the new u-boot requires a different layout by default, it
matches the `openbmc-flash-layout-64.dtsi` but differs from the 32MiB
`openbmc-flash-layout.dtsi`.
So one needs to adjust the `bootcmd` if switching from v2016.07 to v2019.04.


-- 
BRs,
Lei YU


More information about the openbmc mailing list