[PATCH linux dev-5.15 00/26] Add w25q01jvq and convert flash_info format

Fri Feb 25 15:19:51 AEDT 2022

Joel Stanley 於 2022/2/25 下午 12:01 寫道:
> Hi Potin,
>
> On Fri, 25 Feb 2022 at 02:42, Potin Lai <potin.lai at quantatw.com> wrote:
>> This patch series add winbond w25q01jvq flash info and convert flash_info
>> flags in new format to align with upstream (v5.17).
>>
>> The patchs from 01 to 25 are cherry-picked from kernel 5.17, and patch 26
>> is new patch for adding w25q01jvq flash info.
>>
>> LINK: https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.kernel.org%2Fall%2F20220222092222.23108-1-potin.lai%40quantatw.com%2F&data=04%7C01%7Cpotin.lai%40quantatw.com%7C6d400fa8312642184de708d9f8139752%7C179b032707fc4973ac738de7313561b2%7C1%7C0%7C637813585320965043%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=EiinHg%2B1slS1%2BHe14dooydxIDiYPzX%2BLo5ZcoXvZuqA%3D&reserved=0
> I think there was a misunderstanding. Patrick suggested that we simply
> apply the v1 of your patch to support the w25q01jvq to dev-5.15:
>
>  https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.kernel.org%2Fall%2F20211224104522.24615-1-potin.lai%40quantatw.com%2F&data=04%7C01%7Cpotin.lai%40quantatw.com%7C6d400fa8312642184de708d9f8139752%7C179b032707fc4973ac738de7313561b2%7C1%7C0%7C637813585320965043%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=ofd7qkIFG7%2F9%2Bmu53XA%2F4fXidxFn5TvGiE4BNzH5KqE%3D&reserved=0
>
> This avoids the need to backport the new style flash support from
> mainline to v5.15. We avoid large backports where possible as it
> complicates getting fixes: as the patches aren't in mainline v5.15,
> when fixes are selected for backporting, they will not target v5.15 as
> the code the fixes want to fix does not exist in that revision.
> Additionally, large backports carry the risk of regressions, and
> making our bmc kernel less stable.

I just notice that I missed the reply from Patrick of my question (not sure why it was mark as junk mail...), sorry about sending this patch series.

>
> We still want to do the work to upstream support before adding it to
> the openbmc tree. That means next time we rebase on a future release,
> the proper patches will be present. Thanks for doing this.
>
> Another tip when submitting upstream: make sure you use
> --suppress-cc=all, so you don't send the backport emails to the author
> of patches you're backporting.

Got it, thanks a lot for your tip, will add this in future.

>
> I applied v1 of your patch with correction to the chip name.

Thank you for apply v1 patch.

Potin

>
> Cheers,
>
> Joel
>
>> Jonathan Lemon (1):
>>   mtd: spi-nor: Enable locking for n25q128a13
>>
>> Potin Lai (1):
>>   mtd: spi-nor: winbond: Add support for w25q01jvq
>>
>> Tudor Ambarus (24):
>>   mtd: spi-nor: core: Fix spi_nor_flash_parameter otp description
>>   mtd: spi-nor: core: Use container_of to get the pointer to struct
>>     spi_nor
>>   mtd: spi-nor: Get rid of nor->page_size
>>   mtd: spi-nor: core: Introduce the late_init() hook
>>   mtd: spi-nor: atmel: Use flash late_init() for locking
>>   mtd: spi-nor: sst: Use flash late_init() for locking
>>   mtd: spi-nor: winbond: Use manufacturer late_init() for OTP ops
>>   mtd: spi-nor: xilinx: Use manufacturer late_init() to set setup method
>>   mtd: spi-nor: sst: Use manufacturer late_init() to set _write()
>>   mtd: spi-nor: spansion: Use manufacturer late_init()
>>   mtd: spi-nor: Fix mtd size for s3an flashes
>>   mtd: spi-nor: core: Don't use mtd_info in the NOR's probe sequence of
>>     calls
>>   mtd: spi-nor: Introduce spi_nor_set_mtd_info()
>>   mtd: spi-nor: core: Call spi_nor_post_sfdp_fixups() only when SFDP is
>>     defined
>>   mtd: spi-nor: core: Introduce flash_info mfr_flags
>>   mtd: spi-nor: Rework the flash_info flags
>>   mtd: spi-nor: Introduce spi_nor_init_flags()
>>   mtd: spi-nor: Introduce spi_nor_init_fixup_flags()
>>   mtd: spi-nor: core: Init all flash parameters based on SFDP where
>>     possible
>>   mtd: spi-nor: core: Move spi_nor_set_addr_width() in spi_nor_setup()
>>   mtd: spi-nor: winbond: w25q256jvm: Init flash based on SFDP
>>   mtd: spi-nor: spansion: s25fl256s0: Skip SFDP parsing
>>   mtd: spi-nor: gigadevice: gd25q256: Init flash based on SFDP
>>   mtd: spi-nor: issi: is25lp256: Init flash based on SFDP
>>
>>  drivers/mtd/spi-nor/atmel.c      |  79 +++--
>>  drivers/mtd/spi-nor/catalyst.c   |  15 +-
>>  drivers/mtd/spi-nor/core.c       | 536 +++++++++++++++++--------------
>>  drivers/mtd/spi-nor/core.h       | 217 ++++++++-----
>>  drivers/mtd/spi-nor/eon.c        |  33 +-
>>  drivers/mtd/spi-nor/esmt.c       |  15 +-
>>  drivers/mtd/spi-nor/everspin.c   |  12 +-
>>  drivers/mtd/spi-nor/fujitsu.c    |   3 +-
>>  drivers/mtd/spi-nor/gigadevice.c |  57 ++--
>>  drivers/mtd/spi-nor/intel.c      |  12 +-
>>  drivers/mtd/spi-nor/issi.c       |  60 ++--
>>  drivers/mtd/spi-nor/macronix.c   | 105 +++---
>>  drivers/mtd/spi-nor/micron-st.c  | 208 ++++++------
>>  drivers/mtd/spi-nor/otp.c        |   2 +-
>>  drivers/mtd/spi-nor/sfdp.c       |  20 ++
>>  drivers/mtd/spi-nor/spansion.c   | 162 +++++-----
>>  drivers/mtd/spi-nor/sst.c        |  96 ++++--
>>  drivers/mtd/spi-nor/swp.c        |   2 +-
>>  drivers/mtd/spi-nor/winbond.c    | 174 ++++++----
>>  drivers/mtd/spi-nor/xilinx.c     |  21 +-
>>  drivers/mtd/spi-nor/xmc.c        |  10 +-
>>  include/linux/mtd/spi-nor.h      |   2 -
>>  22 files changed, 1045 insertions(+), 796 deletions(-)
>>
>> --
>> 2.17.1
>>