[PATCH U-Boot v2019.04-aspeed-openbmc 4/6] gpio: Enable hogging support in SPL

Andrew Jeffery andrew at aj.id.au
Fri Feb 4 08:43:16 AEDT 2022



On Fri, 4 Feb 2022, at 02:17, Eddie James wrote:
> On 2/2/22 20:11, Andrew Jeffery wrote:
>>
>> On Tue, 25 Jan 2022, at 05:45, Eddie James wrote:
>>> -	if (IS_ENABLED(CONFIG_GPIO_HOG)) {
>>> +#if CONFIG_IS_ENABLED(GPIO_HOG)
>> Why switch to a CPP conditional here?
>>
>> I mean, it's not clear why there was a choice for a C conditional
>> originally, so I'm curious either way.
>
>
> Well I just thought it should match the other conditionals for GPIO_HOG, 
> and it's obviously more efficient at runtime. Other than that, no reason 
> really.

Well, I expect it will be optimised out in the C case anyway.

Doesn't matter too much.

Andrew


More information about the openbmc mailing list