[PATCH U-Boot v2019.04-aspeed-openbmc 5/6] Add GPIO hogging support for AST2600 openbmc config

Eddie James eajames at linux.ibm.com
Fri Feb 4 02:59:24 AEDT 2022


On 2/2/22 20:13, Andrew Jeffery wrote:
>
> On Tue, 25 Jan 2022, at 05:45, Eddie James wrote:
>> Enable GPIO support in the SPL and hog the GPIOs in the SPL only. Also
>> increase the size of the malloc size in the SPL to get the GPIO driver
>> loaded.
>>
>> Signed-off-by: Eddie James <eajames at linux.ibm.com>
>> ---
>>   configs/ast2600_openbmc_spl_emmc_defconfig | 4 +++-
>>   1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/configs/ast2600_openbmc_spl_emmc_defconfig
>> b/configs/ast2600_openbmc_spl_emmc_defconfig
>> index 344a4d8f9c..5f50298a58 100644
>> --- a/configs/ast2600_openbmc_spl_emmc_defconfig
>> +++ b/configs/ast2600_openbmc_spl_emmc_defconfig
>> @@ -11,6 +11,7 @@ CONFIG_SYS_TEXT_BASE=0x81000000
>>   CONFIG_ASPEED_AST2600=y
>>   # CONFIG_ASPEED_LOADERS is not set
>>   CONFIG_TARGET_EVB_AST2600A1=y
>> +CONFIG_SPL_GPIO_SUPPORT=y
>>   CONFIG_SPL_LIBCOMMON_SUPPORT=y
>>   CONFIG_SPL_LIBGENERIC_SUPPORT=y
>>   CONFIG_SYS_MALLOC_F_LEN=0x2000
>> @@ -19,7 +20,7 @@ CONFIG_SPL_SERIAL_SUPPORT=y
>>   CONFIG_SPL_DRIVERS_MISC_SUPPORT=y
>>   CONFIG_ENV_SIZE=0x10000
>>   CONFIG_ENV_OFFSET=0x5000
>> -CONFIG_SPL_SYS_MALLOC_F_LEN=0x800
>> +CONFIG_SPL_SYS_MALLOC_F_LEN=0x1000
> How much capacity does this leave us with? Have you looked at the
> memory layout for the SPL (I haven't, so any legwork you do here is
> appreciated ;) )?


I'm not sure, I haven't looked into it that much. When I was debugging, 
trying to figure out why my SPL wouldn't load, we were right at capacity 
without the GPIO stuff - allocating like 0x7c0 or so. We should have 
plenty more room now. I guess I'm not sure where that memory comes from 
anyway.


Thanks,

Eddie


>
>>   CONFIG_SPL=y
>>   CONFIG_SPL_STACK_R_ADDR=0x90300000
>>   CONFIG_ARMV7_BOOT_SEC_DEFAULT=y
>> @@ -94,6 +95,7 @@ CONFIG_CLK=y
>>   CONFIG_SPL_CLK=y
>>   CONFIG_ASPEED_HACE=y
>>   CONFIG_DM_GPIO=y
>> +CONFIG_SPL_GPIO_HOG=y
>>   CONFIG_ASPEED_GPIO=y
>>   CONFIG_DM_I2C=y
>>   CONFIG_SYS_I2C_ASPEED=y
>> -- 
>> 2.27.0


More information about the openbmc mailing list