[PATCH] gpio: Add gpio_request_by_line_name()

Andrew Jeffery andrew at aj.id.au
Tue Feb 1 08:39:08 AEDT 2022


Hi Fabio, thanks for taking a look.

On Tue, 1 Feb 2022, at 02:40, Fabio Estevam wrote:
> On Mon, Jan 31, 2022 at 9:55 AM Andrew Jeffery <andrew at aj.id.au> wrote:
>>
>> Add support for the upstream gpio-line-names property already described
>> in the common GPIO binding document[1]. The ability to search for a line
>> name allows boards to lift the implementation of common GPIO behaviours
>> away from specific line indexes on a GPIO controller.
>>
>> [1] https://github.com/devicetree-org/dt-schema/blob/3c35bfee83c2e38e2ae7af5f83eb89ca94a521e8/dtschema/schemas/gpio/gpio.yaml#L17
>>
>> Signed-off-by: Andrew Jeffery <andrew at aj.id.au>
>
> Please also add a user for the newly introduced gpio_request_by_line_name().
>
> Otherwise, this is just dead code.

Indeed. I will be working to get some other pieces upstream so I can 
introduce a user of this API. I will resend the patch once I have that 
sorted.

My hope was that I could get a head start on any other feedback people 
might have for the patch while I work to get the other pieces together.

Cheers,

Andrew


More information about the openbmc mailing list