[RESEND][PATCH u-boot v2019.04-aspeed-openbmc v5 1/2] arm/dts: Add IBM Genesis3 board

Patrick Rudolph patrick.rudolph at 9elements.com
Mon Aug 15 15:41:43 AEST 2022


Hi Andrew,
the first and second version of this patch were including ast2500.dtsi
and enabled the devices.
Joel and Zev recommended including the EVB dts to have less copy&paste code.

Please advise how to continue. Both versions are working and have been
send to the ML.

Regards,
Patrick


On Thu, Aug 11, 2022 at 8:17 AM Andrew Jeffery <andrew at aj.id.au> wrote:
>
>
>
> On Thu, 11 Aug 2022, at 15:30, Patrick Rudolph wrote:
> > There's no SD card slot, there are two MACs in RGMII mode and nothing
> > that's required to boot on i2c bus.
> > In the defconfig used I disabled SD card and I2C support, so this is
> > not an issue.
> > Should I still disable it in the devicetree, just for reference?
>
> It's at least more idiomatic to `#include "ast2500.dtsi"` and then
> enable the controllers you require, rather than #including the dts for a
> board not entirely related to the design you're bringing up.
>
> That would be my preference. Is the result much more verbose? It feels
> like it shouldn't be if you only need networking and SPI flash.
>
> Andrew


More information about the openbmc mailing list