TODO items for the AST2600 PWM driver

[Peter Delevoryas]

On Thu, Aug 11, 2022 at 10:55:34AM +0000, Billy Tsai wrote:
> Hi Peter,
> 
> Thanks for your organization.
> 
> On 2022/8/11, 5:12 AM, "Peter Delevoryas" <peter at pjd.dev> wrote:
> 
>     > Hey Joel and Billy,
>   
>     > I was looking at this thread from 2021, and I'm trying to figure out
>     > what we need to change to get the driver accepted upstream.
>   
>     > CACPK8XfM4C7v3keXaxMs9SkqNzb8XWbZ6QvcZXWcy3ZKJCrvWQ at mail.gmail.com <https://lore.kernel.org/lkml/<a href=>/">https://lore.kernel.org/lkml/CACPK8XfM4C7v3keXaxMs9SkqNzb8XWbZ6QvcZXWcy3ZKJCrvWQ@mail.gmail.com/
>   
>     > It seems like there's a few major things:
>   
>     > 1. Use one device tree binding, and one driver file.
>     > 2. Should be a hwmon driver and not a pwm driver.
>     > 3. Don't use regmap.
> 
> I agree to use one device tree binding and don't use regmap.
> I will fix these in the next patch.

Ok great, thanks.

> But, I am still confused by treating the PWM device to be a hwmon driver and not a PWM driver.
> As I menthion in https://lore.kernel.org/lkml/ADD1E8B8-60F0-442A-BEF1-1AA304454963@aspeedtech.com/
> I will try to add the reason, why I want to treat the driver as PWM driver instead of hwmon driver, as the link above in the next patch.

Ok, cc peter at pjd.dev

> If you have any advice, please let me know.

I'm still not 100% up to speed on this series, but it seems like having
a different kind of driver than the ast2500 is a sticking point. I would
guess that the upstream would prefer if we changed the ast2500 driver to
pwm too, or put the ast2600 driver in hwmon, but they might not like
having the ast2500 in hwmon and the ast2600 in pwm. I still don't
understand the full context of this though, maybe I'm misunderstanding.

Thanks,
Peter

> 
> Thanks,
> Billy
> 
> 
>     > And, is anybody working on this at the moment? Can someone else pick this up?
>   
>     > Thanks,
>     > Peter
>   
>