[PATCH v5 01/11] archh: arm: mach-hpe: Introduce the HPE GXP architecture

Arnd Bergmann arnd at arndb.de
Fri Apr 22 23:20:11 AEST 2022


On Thu, Apr 21, 2022 at 9:21 PM <nick.hawkins at hpe.com> wrote:
> +
> +DT_MACHINE_START(GXP_DT, "HPE GXP")
> +       .dt_compat      = gxp_board_dt_compat,
> +       .l2c_aux_val = 0,
> +       .l2c_aux_mask = 0,
> +MACHINE_END

Ther l2c initialization looks wrong here, where  you are saying here is
that all the bits of the aux register must be set to zero.

I also see that you don't have a device node for the cache controller, so
this is probably not actually used, but in general there should be one with
the correct properties.

        Arnd


More information about the openbmc mailing list