[PATCH v2] ARM: dts: aspeed: Adding Inventec Transformers BMC
Joel Stanley
joel at jms.id.au
Tue Oct 19 10:48:38 AEDT 2021
On Mon, 18 Oct 2021 at 23:43, Joel Stanley <joel at jms.id.au> wrote:
>
> On Mon, 18 Oct 2021 at 22:51, Lin.TommySC 林世欽 TAO
> <Lin.TommySC at inventec.com> wrote:
> >
> > Initial introduction of Inventec Transformers x86 family equipped with AST2600 BMC SoC.
> >
> > Signed-off-by: Tommy Lin <Lin.TommySC at inventec.com>
>
> Reviewed-by: Joel Stanley <joel at jms.id.au>
>
> Thanks! I've applied this to the aspeed tree (but I've already sent my
> pull request for v5.16) and to the openbmc tree.
I spoke too soon! The patch introduces a lot of warnings that I will
get you to fix before I apply. Please apply your patch to v5.15-rc1
and build it to ensure you have seen all of the warnings.
> > + pwm_tacho {
> > + status = "okay";
> > + pinctrl-names = "default";
> > + fan at 0 {
> > + reg = <0x00>;
> > + aspeed,target_pwm = <25000>;
> > + cooling-levels = <125 151 177 203 229 255>;
> > + aspeed,fan-tach-ch = <0x00>;
> > + aspeed,min_rpm = <750000>;
DTC arch/arm/boot/dts/aspeed-bmc-inventec-transformers.dtb
../arch/arm/boot/dts/aspeed-bmc-inventec-transformers.dts:70.24-37:
Warning (reg_format): /pwm_tacho/fan at 0:reg: property has invalid
length (4 bytes) (#address-cells == 2, #size-cells == 1)
../arch/arm/boot/dts/aspeed-bmc-inventec-transformers.dts:78.24-37:
Warning (reg_format): /pwm_tacho/fan at 1:reg: property has invalid
length (4 bytes) (#address-cells == 2, #size-cells == 1)
../arch/arm/boot/dts/aspeed-bmc-inventec-transformers.dts:86.24-37:
Warning (reg_format): /pwm_tacho/fan at 2:reg: property has invalid
length (4 bytes) (#address-cells == 2, #size-cells == 1)
../arch/arm/boot/dts/aspeed-bmc-inventec-transformers.dts:94.24-37:
Warning (reg_format): /pwm_tacho/fan at 3:reg: property has invalid
length (4 bytes) (#address-cells == 2, #size-cells == 1)
../arch/arm/boot/dts/aspeed-bmc-inventec-transformers.dts:102.24-37:
Warning (reg_format): /pwm_tacho/fan at 4:reg: property has invalid
length (4 bytes) (#address-cells == 2, #size-cells == 1)
../arch/arm/boot/dts/aspeed-bmc-inventec-transformers.dts:110.24-37:
Warning (reg_format): /pwm_tacho/fan at 5:reg: property has invalid
length (4 bytes) (#address-cells == 2, #size-cells == 1)
../arch/arm/boot/dts/aspeed-bmc-inventec-transformers.dts:118.24-37:
Warning (reg_format): /pwm_tacho/fan at 6:reg: property has invalid
length (4 bytes) (#address-cells == 2, #size-cells == 1)
../arch/arm/boot/dts/aspeed-bmc-inventec-transformers.dts:126.24-37:
Warning (reg_format): /pwm_tacho/fan at 7:reg: property has invalid
length (4 bytes) (#address-cells == 2, #size-cells == 1)
../arch/arm/boot/dts/aspeed-bmc-inventec-transformers.dts:134.24-37:
Warning (reg_format): /pwm_tacho/fan at 8:reg: property has invalid
length (4 bytes) (#address-cells == 2, #size-cells == 1)
../arch/arm/boot/dts/aspeed-bmc-inventec-transformers.dts:139.24-37:
Warning (reg_format): /pwm_tacho/fan at 9:reg: property has invalid
length (4 bytes) (#address-cells == 2, #size-cells == 1)
../arch/arm/boot/dts/aspeed-bmc-inventec-transformers.dts:144.24-37:
Warning (reg_format): /pwm_tacho/fan at 10:reg: property has invalid
length (4 bytes) (#address-cells == 2, #size-cells == 1)
../arch/arm/boot/dts/aspeed-bmc-inventec-transformers.dts:149.24-37:
Warning (reg_format): /pwm_tacho/fan at 11:reg: property has invalid
length (4 bytes) (#address-cells == 2, #size-cells == 1)
../arch/arm/boot/dts/aspeed-bmc-inventec-transformers.dts:154.24-37:
Warning (reg_format): /pwm_tacho/fan at 12:reg: property has invalid
length (4 bytes) (#address-cells == 2, #size-cells == 1)
../arch/arm/boot/dts/aspeed-bmc-inventec-transformers.dts:159.24-37:
Warning (reg_format): /pwm_tacho/fan at 13:reg: property has invalid
length (4 bytes) (#address-cells == 2, #size-cells == 1)
../arch/arm/boot/dts/aspeed-bmc-inventec-transformers.dts:164.24-37:
Warning (reg_format): /pwm_tacho/fan at 14:reg: property has invalid
length (4 bytes) (#address-cells == 2, #size-cells == 1)
../arch/arm/boot/dts/aspeed-bmc-inventec-transformers.dts:169.24-37:
Warning (reg_format): /pwm_tacho/fan at 15:reg: property has invalid
length (4 bytes) (#address-cells == 2, #size-cells == 1)
arch/arm/boot/dts/aspeed-bmc-inventec-transformers.dtb: Warning
(pci_device_reg): Failed prerequisite 'reg_format'
arch/arm/boot/dts/aspeed-bmc-inventec-transformers.dtb: Warning
(pci_device_bus_num): Failed prerequisite 'reg_format'
arch/arm/boot/dts/aspeed-bmc-inventec-transformers.dtb: Warning
(i2c_bus_reg): Failed prerequisite 'reg_format'
arch/arm/boot/dts/aspeed-bmc-inventec-transformers.dtb: Warning
(spi_bus_reg): Failed prerequisite 'reg_format'
../arch/arm/boot/dts/aspeed-bmc-inventec-transformers.dts:69.22-75.18:
Warning (avoid_default_addr_size): /pwm_tacho/fan at 0: Relying on
default #address-cells value
../arch/arm/boot/dts/aspeed-bmc-inventec-transformers.dts:69.22-75.18:
Warning (avoid_default_addr_size): /pwm_tacho/fan at 0: Relying on
default #size-cells value
../arch/arm/boot/dts/aspeed-bmc-inventec-transformers.dts:77.22-83.18:
Warning (avoid_default_addr_size): /pwm_tacho/fan at 1: Relying on
default #address-cells value
../arch/arm/boot/dts/aspeed-bmc-inventec-transformers.dts:77.22-83.18:
Warning (avoid_default_addr_size): /pwm_tacho/fan at 1: Relying on
default #size-cells value
../arch/arm/boot/dts/aspeed-bmc-inventec-transformers.dts:85.22-91.18:
Warning (avoid_default_addr_size): /pwm_tacho/fan at 2: Relying on
default #address-cells value
../arch/arm/boot/dts/aspeed-bmc-inventec-transformers.dts:85.22-91.18:
Warning (avoid_default_addr_size): /pwm_tacho/fan at 2: Relying on
default #size-cells value
../arch/arm/boot/dts/aspeed-bmc-inventec-transformers.dts:93.22-99.18:
Warning (avoid_default_addr_size): /pwm_tacho/fan at 3: Relying on
default #address-cells value
../arch/arm/boot/dts/aspeed-bmc-inventec-transformers.dts:93.22-99.18:
Warning (avoid_default_addr_size): /pwm_tacho/fan at 3: Relying on
default #size-cells value
../arch/arm/boot/dts/aspeed-bmc-inventec-transformers.dts:101.22-107.18:
Warning (avoid_default_addr_size): /pwm_tacho/fan at 4: Relying on
default #address-cells value
../arch/arm/boot/dts/aspeed-bmc-inventec-transformers.dts:101.22-107.18:
Warning (avoid_default_addr_size): /pwm_tacho/fan at 4: Relying on
default #size-cells value
../arch/arm/boot/dts/aspeed-bmc-inventec-transformers.dts:109.22-115.18:
Warning (avoid_default_addr_size): /pwm_tacho/fan at 5: Relying on
default #address-cells value
../arch/arm/boot/dts/aspeed-bmc-inventec-transformers.dts:109.22-115.18:
Warning (avoid_default_addr_size): /pwm_tacho/fan at 5: Relying on
default #size-cells value
../arch/arm/boot/dts/aspeed-bmc-inventec-transformers.dts:117.22-123.18:
Warning (avoid_default_addr_size): /pwm_tacho/fan at 6: Relying on
default #address-cells value
../arch/arm/boot/dts/aspeed-bmc-inventec-transformers.dts:117.22-123.18:
Warning (avoid_default_addr_size): /pwm_tacho/fan at 6: Relying on
default #size-cells value
../arch/arm/boot/dts/aspeed-bmc-inventec-transformers.dts:125.22-131.18:
Warning (avoid_default_addr_size): /pwm_tacho/fan at 7: Relying on
default #address-cells value
../arch/arm/boot/dts/aspeed-bmc-inventec-transformers.dts:125.22-131.18:
Warning (avoid_default_addr_size): /pwm_tacho/fan at 7: Relying on
default #size-cells value
../arch/arm/boot/dts/aspeed-bmc-inventec-transformers.dts:133.22-136.18:
Warning (avoid_default_addr_size): /pwm_tacho/fan at 8: Relying on
default #address-cells value
../arch/arm/boot/dts/aspeed-bmc-inventec-transformers.dts:133.22-136.18:
Warning (avoid_default_addr_size): /pwm_tacho/fan at 8: Relying on
default #size-cells value
../arch/arm/boot/dts/aspeed-bmc-inventec-transformers.dts:138.22-141.18:
Warning (avoid_default_addr_size): /pwm_tacho/fan at 9: Relying on
default #address-cells value
../arch/arm/boot/dts/aspeed-bmc-inventec-transformers.dts:138.22-141.18:
Warning (avoid_default_addr_size): /pwm_tacho/fan at 9: Relying on
default #size-cells value
../arch/arm/boot/dts/aspeed-bmc-inventec-transformers.dts:143.23-146.18:
Warning (avoid_default_addr_size): /pwm_tacho/fan at 10: Relying on
default #address-cells value
../arch/arm/boot/dts/aspeed-bmc-inventec-transformers.dts:143.23-146.18:
Warning (avoid_default_addr_size): /pwm_tacho/fan at 10: Relying on
default #size-cells value
../arch/arm/boot/dts/aspeed-bmc-inventec-transformers.dts:148.23-151.18:
Warning (avoid_default_addr_size): /pwm_tacho/fan at 11: Relying on
default #address-cells value
../arch/arm/boot/dts/aspeed-bmc-inventec-transformers.dts:148.23-151.18:
Warning (avoid_default_addr_size): /pwm_tacho/fan at 11: Relying on
default #size-cells value
../arch/arm/boot/dts/aspeed-bmc-inventec-transformers.dts:153.23-156.18:
Warning (avoid_default_addr_size): /pwm_tacho/fan at 12: Relying on
default #address-cells value
../arch/arm/boot/dts/aspeed-bmc-inventec-transformers.dts:153.23-156.18:
Warning (avoid_default_addr_size): /pwm_tacho/fan at 12: Relying on
default #size-cells value
../arch/arm/boot/dts/aspeed-bmc-inventec-transformers.dts:158.23-161.18:
Warning (avoid_default_addr_size): /pwm_tacho/fan at 13: Relying on
default #address-cells value
../arch/arm/boot/dts/aspeed-bmc-inventec-transformers.dts:158.23-161.18:
Warning (avoid_default_addr_size): /pwm_tacho/fan at 13: Relying on
default #size-cells value
../arch/arm/boot/dts/aspeed-bmc-inventec-transformers.dts:163.23-166.18:
Warning (avoid_default_addr_size): /pwm_tacho/fan at 14: Relying on
default #address-cells value
../arch/arm/boot/dts/aspeed-bmc-inventec-transformers.dts:163.23-166.18:
Warning (avoid_default_addr_size): /pwm_tacho/fan at 14: Relying on
default #size-cells value
../arch/arm/boot/dts/aspeed-bmc-inventec-transformers.dts:168.23-171.18:
Warning (avoid_default_addr_size): /pwm_tacho/fan at 15: Relying on
default #address-cells value
../arch/arm/boot/dts/aspeed-bmc-inventec-transformers.dts:168.23-171.18:
Warning (avoid_default_addr_size): /pwm_tacho/fan at 15: Relying on
default #size-cells value
> > + };
> > +
> > + fan at 1 {
> > + reg = <0x01>;
> > + aspeed,target_pwm = <25000>;
> > + cooling-levels = <125 151 177 203 229 255>;
> > + aspeed,fan-tach-ch = <0x01>;
> > + aspeed,min_rpm = <750000>;
> > + };
> > +
> > + fan at 2 {
> > + reg = <0x02>;
> > + aspeed,target_pwm = <25000>;
> > + cooling-levels = <125 151 177 203 229 255>;
> > + aspeed,fan-tach-ch = <0x02>;
> > + aspeed,min_rpm = <750000>;
> > + };
> > +
> > + fan at 3 {
> > + reg = <0x03>;
> > + aspeed,target_pwm = <25000>;
> > + cooling-levels = <125 151 177 203 229 255>;
> > + aspeed,fan-tach-ch = <0x03>;
> > + aspeed,min_rpm = <750000>;
> > + };
> > +
> > + fan at 4 {
> > + reg = <0x04>;
> > + aspeed,target_pwm = <25000>;
> > + cooling-levels = <125 151 177 203 229 255>;
> > + aspeed,fan-tach-ch = <0x04>;
> > + aspeed,min_rpm = <750000>;
> > + };
> > +
> > + fan at 5 {
> > + reg = <0x05>;
> > + aspeed,target_pwm = <25000>;
> > + cooling-levels = <125 151 177 203 229 255>;
> > + aspeed,fan-tach-ch = <0x05>;
> > + aspeed,min_rpm = <750000>;
> > + };
> > +
> > + fan at 6 {
> > + reg = <0x06>;
> > + aspeed,target_pwm = <25000>;
> > + cooling-levels = <125 151 177 203 229 255>;
> > + aspeed,fan-tach-ch = <0x06>;
> > + aspeed,min_rpm = <750000>;
> > + };
> > +
> > + fan at 7 {
> > + reg = <0x07>;
> > + aspeed,target_pwm = <25000>;
> > + cooling-levels = <125 151 177 203 229 255>;
> > + aspeed,fan-tach-ch = <0x07>;
> > + aspeed,min_rpm = <750000>;
> > + };
> > +
> > + fan at 8 {
> > + reg = <0x08>;
> > + aspeed,fan-tach-ch = <0x08>;
> > + };
> > +
> > + fan at 9 {
> > + reg = <0x09>;
> > + aspeed,fan-tach-ch = <0x09>;
> > + };
> > +
> > + fan at 10 {
> > + reg = <0x0a>;
> > + aspeed,fan-tach-ch = <0x0a>;
> > + };
> > +
> > + fan at 11 {
> > + reg = <0x0b>;
> > + aspeed,fan-tach-ch = <0x0b>;
> > + };
> > +
> > + fan at 12 {
> > + reg = <0x0c>;
> > + aspeed,fan-tach-ch = <0x0c>;
> > + };
> > +
> > + fan at 13 {
> > + reg = <0x0d>;
> > + aspeed,fan-tach-ch = <0x0d>;
> > + };
> > +
> > + fan at 14 {
> > + reg = <0x0e>;
> > + aspeed,fan-tach-ch = <0x0e>;
> > + };
> > +
> > + fan at 15 {
> > + reg = <0x0f>;
> > + aspeed,fan-tach-ch = <0x0f>;
> > + };
> > + };
> > +};
> > +
> > +&mdio0 {
> > + status = "okay";
> > +
> > + ethphy0: ethernet-phy at 0 {
> > + compatible = "ethernet-phy-ieee802.3-c22";
> > + reg = <1>;
> > + };
> > +};
> > +
> > +&mac3 {
> > + status = "okay";
> > + phy-mode = "rgmii";
> > + phy-handle = <ðphy0>;
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pinctrl_rgmii4_default>;
> > +};
> > +
> > +&fmc {
> > + status = "okay";
> > +
> > + flash at 0 {
> > + status = "okay";
> > + m25p,fast-read;
> > + label = "bmc";
> > + spi-max-frequency = <33000000>;
> > + spi-tx-bus-width = <2>;
> > + spi-rx-bus-width = <2>;
> > +#include "openbmc-flash-layout.dtsi"
> > + };
> > +
> > + flash at 1 {
> > + status = "okay";
> > + m25p,fast-read;
> > + label = "bmc2";
> > + spi-max-frequency = <33000000>;
> > + spi-tx-bus-width = <2>;
> > + spi-rx-bus-width = <2>;
> > + };
> > +};
> > +
> > +&spi1 {
> > + status = "okay";
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pinctrl_spi1_default>;
> > +
> > + flash at 0 {
> > + status = "okay";
> > + m25p,fast-read;
> > + label = "bios";
> > + spi-max-frequency = <33000000>;
> > + spi-tx-bus-width = <1>;
> > + spi-rx-bus-width = <1>;
> > + };
> > +};
> > +
> > +&wdt1 {
> > + status = "okay";
> > +};
> > +
> > +&uart1 {
> > + status = "okay";
> > +};
> > +
> > +&uart5 {
> > + status = "okay";
> > +};
> > +
> > +&i2c0 {
> > + status = "okay";
> > +
> > + //Set bmc' slave address;
> > + bmc_slave at 10 {
> > + compatible = "ipmb-dev";
> > + reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;
> > + i2c-protocol;
> > + };
> > +};
> > +
> > +&i2c2 {
> > + status = "okay";
> > +};
> > +
> > +&i2c3 {
> > + // FRU AT24C512C-SSHM-T
> > + status = "okay";
> > + eeprom at 50 {
> > + compatible = "atmel,24c512";
> > + reg = <0x50>;
> > + pagesize = <128>;
> > + };
> > +};
> > +
> > +&i2c5 {
> > + status = "okay";
> > +};
> > +
> > +&i2c6 {
> > + status = "okay";
> > +
> > + tmp75 at 49 {
> > + compatible = "ti,tmp75";
> > + reg = <0x49>;
> > + };
> > +
> > + tmp75 at 4f {
> > + compatible = "ti,tmp75";
> > + reg = <0x4f>;
> > + };
> > +
> > + tmp468 at 48 {
> > + compatible = "ti,tmp468";
> > + reg = <0x48>;
> > + };
> > +};
> > +
> > +&i2c7 {
> > + status = "okay";
> > + adm1278 at 40 {
> > + compatible = "adi,adm1278";
> > + reg = <0x40>;
> > + };
> > +};
> > +
> > +
> > +&i2c8 {
> > + // FRU AT24C512C-SSHM-T
> > + status = "okay";
> > +
> > + eeprom at 51 {
> > + compatible = "atmel,24c512";
> > + reg = <0x51>;
> > + pagesize = <128>;
> > + };
> > +
> > + eeprom at 53 {
> > + compatible = "atmel,24c512";
> > + reg = <0x53>;
> > + pagesize = <128>;
> > + };
> > +};
> > +
> > +&i2c9 {
> > + // M.2
> > + status = "okay";
> > +};
> > +
> > +&i2c10 {
> > + // I2C EXPANDER
> > + status = "okay";
> > +
> > + i2c-switch at 71 {
> > + compatible = "nxp,pca9544";
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + reg = <0x71>;
> > + };
> > +
> > + i2c-switch at 73 {
> > + compatible = "nxp,pca9544";
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + reg = <0x73>;
> > + };
> > +};
> > +
> > +&i2c11 {
> > + // I2C EXPANDER
> > + status = "okay";
> > +
> > + i2c-switch at 70 {
> > + compatible = "nxp,pca9544";
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + reg = <0x70>;
> > +
> > + pcie_eeprom_riser1: i2c at 0 {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + reg = <0>;
> > +
> > + eeprom at 55 {
> > + compatible = "atmel,24c512";
> > + reg = <0x55>;
> > + pagesize = <128>;
> > + };
> > + };
> > +
> > + pcie_eeprom_riser2: i2c at 1 {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + reg = <1>;
> > +
> > + eeprom at 55 {
> > + compatible = "atmel,24c512";
> > + reg = <0x55>;
> > + pagesize = <128>;
> > + };
> > + };
> > +
> > + pcie_eeprom_riser3: i2c at 2 {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + reg = <2>;
> > +
> > + eeprom at 55 {
> > + compatible = "atmel,24c512";
> > + reg = <0x55>;
> > + pagesize = <128>;
> > + };
> > + };
> > + };
> > +};
> > +
> > +&i2c12 {
> > + status = "okay";
> > +
> > + psu0:psu0 at 58 {
> > + compatible = "pmbus";
> > + reg = <0x58>;
> > + };
> > +};
> > +
> > +&gpio0 {
> > + status = "okay";
> > + gpio-line-names =
> > + /*A0-A7*/ "","","","","","","","",
> > + /*B0-B7*/ "presence-ps0","power-chassis-good","","","","","presence-ps1","",
> > + /*C0-C7*/ "","","","","","","","",
> > + /*D0-D7*/ "","","","","","","","",
> > + /*E0-E7*/ "","","","","","","","",
> > + /*F0-F7*/ "","","","","power-chassis-control","","","",
> > + /*G0-G7*/ "","","jtag-mux","","","","","",
> > + /*H0-H7*/ "","","","","reset-button","power-button","","",
> > + /*I0-I7*/ "","","","","","","","",
> > + /*J0-J7*/ "","","","","","","","",
> > + /*K0-K7*/ "","","","","","","","",
> > + /*L0-L7*/ "","","","","","","","",
> > + /*M0-M7*/ "","","","","","","","",
> > + /*N0-N7*/ "","","","","","","","",
> > + /*O0-O7*/ "","","","","","","","",
> > + /*P0-P7*/ "","","","tck-mux","","","","",
> > + /*Q0-Q7*/ "","","","","","","","",
> > + /*R0-R7*/ "","","","","","","","",
> > + /*S0-S7*/ "","","","","","","","",
> > + /*T0-T7*/ "","","","","","","","",
> > + /*U0-U7*/ "","nmi-button","","","","","","",
> > + /*V0-V7*/ "","","","","power-config-full-load","","","",
> > + /*W0-W7*/ "","","","","","","","",
> > + /*X0-X7*/ "","","","","","","","",
> > + /*Y0-Y7*/ "","","","","","","","",
> > + /*Z0-Z7*/ "","","","","","","","",
> > + /*AA0-AA7*/ "","","","","","","","",
> > + /*AB0-AB7*/ "","","","","","","","",
> > + /*AC0-AC7*/ "","","","","","","","";
> > +};
> > +
> > +&lpc_snoop {
> > + status = "okay";
> > + snoop-ports = <0x80>;
> > +};
> > +
> > +&emmc_controller {
> > + status = "okay";
> > +};
> > +
> > +&emmc {
> > + status = "okay";
> > + non-removable;
> > + max-frequency = <52000000>;
> > + bus-width = <8>;
> > +};
> > +
> > +&vhub {
> > + status = "okay";
> > + aspeed,vhub-downstream-ports = <7>;
> > + aspeed,vhub-generic-endpoints = <21>;
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pinctrl_usb2ad_default>;
> > +};
> > +
> > +&rtc {
> > + status = "okay";
> > +};
> > --
> > 2.33.0
> >
More information about the openbmc
mailing list