[PATCH linux dev-5.14 3/8] hwmon: (pmbus/lm25066) Avoid forward declaration of lm25066_id
Zev Weiss
zev at bewilderbeest.net
Tue Oct 19 10:17:09 AEDT 2021
Reordering things to put the table before the probe function
eliminates the need for it.
Signed-off-by: Zev Weiss <zev at bewilderbeest.net>
Link: https://lore.kernel.org/r/20210928092242.30036-4-zev@bewilderbeest.net
Signed-off-by: Guenter Roeck <linux at roeck-us.net>
---
drivers/hwmon/pmbus/lm25066.c | 23 ++++++++++-------------
1 file changed, 10 insertions(+), 13 deletions(-)
diff --git a/drivers/hwmon/pmbus/lm25066.c b/drivers/hwmon/pmbus/lm25066.c
index 3616705aafde..4dc003ff859e 100644
--- a/drivers/hwmon/pmbus/lm25066.c
+++ b/drivers/hwmon/pmbus/lm25066.c
@@ -234,8 +234,6 @@ struct lm25066_data {
#define to_lm25066_data(x) container_of(x, struct lm25066_data, info)
-static const struct i2c_device_id lm25066_id[];
-
static int lm25066_read_word_data(struct i2c_client *client, int page,
int phase, int reg)
{
@@ -436,6 +434,16 @@ static int lm25066_write_word_data(struct i2c_client *client, int page, int reg,
return ret;
}
+static const struct i2c_device_id lm25066_id[] = {
+ {"lm25056", lm25056},
+ {"lm25066", lm25066},
+ {"lm5064", lm5064},
+ {"lm5066", lm5066},
+ {"lm5066i", lm5066i},
+ { }
+};
+MODULE_DEVICE_TABLE(i2c, lm25066_id);
+
static int lm25066_probe(struct i2c_client *client)
{
int config;
@@ -509,17 +517,6 @@ static int lm25066_probe(struct i2c_client *client)
return pmbus_do_probe(client, info);
}
-static const struct i2c_device_id lm25066_id[] = {
- {"lm25056", lm25056},
- {"lm25066", lm25066},
- {"lm5064", lm5064},
- {"lm5066", lm5066},
- {"lm5066i", lm5066i},
- { }
-};
-
-MODULE_DEVICE_TABLE(i2c, lm25066_id);
-
/* This is the driver that will be inserted */
static struct i2c_driver lm25066_driver = {
.driver = {
--
2.33.1
More information about the openbmc
mailing list