Making obmc-console_git.bb more generic (again)?
Oskar Senft
osk at google.com
Thu Nov 18 09:01:25 AEDT 2021
Hi everyone
I noticed that as of
https://gerrit.openbmc-project.xyz/c/openbmc/openbmc/+/30369 (aka
https://github.com/openbmc/openbmc/commit/abf95efe7c3a34cc2e5d7424abb59710fb4a1d4d),
obmc-console_git.bb assumes that we always want to use ttyVUART0.
We used to have support for OBMC_CONSOLE_HOST_TTY and then create the
symlink /etc/obmc-console/server.${OBMC_CONSOLE_HOST_TTY}.conf as
needed.
>From what I can tell, OBMC_CONSOLE_HOST_TTY is still used in quite a
few machine layers. Some of them (e.g. meta-amd and meta-facebook)
even went so far to replicate the previous behavior by deleting
/etc/obmc-console/server.VUART0.conf and then re-creating the correct
one.
Is this actually the expected behavior? Or was that just an oversight
in the commit?
I'd be happy to send a review request to make this generic again if
people agree. A bunch of follow-up commits could then remove the
duplicate code in individual machine layer overrides.
Thanks
Oskar.
More information about the openbmc
mailing list