[RFC PATCH] ARM: aspeed: Add secure boot controller support

Joel Stanley joel at jms.id.au
Wed Nov 17 14:03:56 AEDT 2021


On Tue, 16 Nov 2021 at 10:15, Paul Menzel <pmenzel at molgen.mpg.de> wrote:

> >>> +     if (has_sbe && (security_status & SECURE_BOOT))
> >>> +             pr_info("AST2600 secure boot enabled\n");
> >>> +
> >>
> >> Maybe it is more interesting to log, when it is not enabled?
> >
> > By default the soc will boot without secure boot, and this is not a
> > problem. It is informative to know that the system has been configured
> > with secure boot as this indicates the system has it enabled, and has
> > correctly booted (otherwise you would not see any message).
>
> Maybe log a message in both cases? Linux also logs the message below on
> my old Dell Intel laptop:
>
>      [    0.000000] secureboot: Secure boot could not be determined (mode 0)

I'll print a message either way, as long as the secure boot controller
compatible was found.

Thanks for the review.

Cheers,

Joel


More information about the openbmc mailing list