[PATCH v2] Documentation: checkpatch: Tweak BIT() macro include
dwaipayanray1 at gmail.com
Thu May 20 20:15:20 AEST 2021
On Thu, May 20, 2021 at 3:10 PM Andrew Jeffery <andrew at aj.id.au> wrote:
> While include/linux/bitops.h brings in the BIT() macro, it was moved to
> include/linux/bits.h in commit 8bd9cb51daac ("locking/atomics, asm-generic:
> Move some macros from <linux/bitops.h> to a new <linux/bits.h> file").
> Since that commit BIT() has moved again into include/vdso/bits.h via
> commit 3945ff37d2f4 ("linux/bits.h: Extract common header for vDSO").
> I think the move to the vDSO header can be considered an implementation
> detail, so for now update the checkpatch documentation to recommend use
> of include/linux/bits.h.
> Cc: Jiri Slaby <jirislaby at kernel.org>
> Acked-by: Jiri Slaby <jirislaby at kernel.org>
Looks good to me. Thanks.
Acked-by: Dwaipayan Ray <dwaipayanray1 at gmail.com>
> Signed-off-by: Andrew Jeffery <andrew at aj.id.au>
> Documentation/dev-tools/checkpatch.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/Documentation/dev-tools/checkpatch.rst b/Documentation/dev-tools/checkpatch.rst
> index 51fed1bd72ec..59fcc9f627ea 100644
> --- a/Documentation/dev-tools/checkpatch.rst
> +++ b/Documentation/dev-tools/checkpatch.rst
> @@ -472,7 +472,7 @@ Macros, Attributes and Symbols
> Defines like: 1 << <digit> could be BIT(digit).
> - The BIT() macro is defined in include/linux/bitops.h::
> + The BIT() macro is defined via include/linux/bits.h::
> #define BIT(nr) (1UL << (nr))
More information about the openbmc