Re: [PATCH linux dev-5.10 v3 09/18] ipmi: kcs_bmc: Allow clients to control KCS IRQ state

[Andrew Jeffery]

On Fri, 14 May 2021, at 12:16, CS20 KWLiu wrote:
> >-----Original Message-----
> >diff --git a/drivers/char/ipmi/kcs_bmc_npcm7xx.c
> >b/drivers/char/ipmi/kcs_bmc_npcm7xx.c
> >index 9f0b168e487c..f8b7162fb830 100644
> >--- a/drivers/char/ipmi/kcs_bmc_npcm7xx.c
> >+++ b/drivers/char/ipmi/kcs_bmc_npcm7xx.c
> >@@ -38,6 +38,7 @@
> > #define KCS2CTL               0x2A
> > #define KCS3CTL               0x3C
> > #define    KCS_CTL_IBFIE      BIT(0)
> >+#define    KCS_CTL_OBEIE      BIT(0)
> 
> Hi Andrew:
> 
> Appreciate all of your hard work and effort.
> 
> There is a wrong definition of kcs_bmc_npcm7xx.c.
> The OBEIE bit offset in nuvoton BMC is 1.
> #define    KCS_CTL_OBEIE        BIT(1)
> 

Ah! Good catch. Thanks Joseph.

I'll blame a copy/paste brain-fade and a lack of hardware* :)

Andrew

* Unfortunately qemu says:

$ grep -i kcs $(git ls-files | grep npcm)
hw/arm/npcm7xx.c:    create_unimplemented_device("npcm7xx.kcs",          0xf0007000,   4 * KiB);