[PATCH linux dev-5.10 1/3] ARM: dts: aspeed: rainier: Enable fan watchdog

[Joel Stanley]

On Wed, 10 Mar 2021 at 17:32, Eddie James <eajames at linux.ibm.com> wrote:
>
> Set watchdog 1 to pulse the fan watchdog circuit that drives the FAULT
> pin of the MAX31785, resulting in fans running at full speed, if at
> any point the BMC stops pulsing it, such as a BMC reboot at runtime.
> Enable watchdog 2 for BMC reboots.

This patch looks okay, assuming you have tested rebooting still works.

Have we tested that u-boot reboots still work, and do not trigger the reset?

Have you considered making a common ibm-p10 device tree, and
including/removing nodes as appropriate for the various rainier and
everest systems? I think this will reduce the work required to
maintain the trees, particularly as it avoids adding changes like this
twice.

Cheers,

Joel


>
> Signed-off-by: Matthew Barth <msbarth at linux.ibm.com>
> Signed-off-by: Eddie James <eajames at linux.ibm.com>
> ---
>  arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts b/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
> index 85fb60d16fdf..9f34136ec40f 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts
> @@ -3193,6 +3193,20 @@ flash at 0 {
>         };
>  };
>
> +&wdt1 {
> +       aspeed,reset-type = "none";
> +       aspeed,external-signal;
> +       aspeed,ext-push-pull;
> +       aspeed,ext-active-high;
> +
> +       pinctrl-names = "default";
> +       pinctrl-0 = <&pinctrl_wdtrst1_default>;
> +};
> +
> +&wdt2 {
> +       status = "okay";
> +};
> +
>  &xdma {
>         status = "okay";
>         memory-region = <&vga_memory>;
> --
> 2.27.0
>