x86-power-control: NMI Enabled

[Andrei Kartashev]

Hello,

I was a bit confused today when I found that x86-power-control uses
undocumented "Enabled" property of
xyz.openbmc_project.Chassis.Control.NMISource interface (see links
below).
The xyz.openbmc_project.Chassis.Control.NMISource is hosted by Settings
daemon and thus should store persistent configuration information.

According to the sources, "Enabled" is used to store internal state of
NMI operation or even to trigger NMI. My confusion is about if it
really required to have this state to be persistent over reboot? I
almost sure, it doesn't. But even if it does, it should not be hosted
by Settings daemon as semantically it is not a configuration option.

Does anyone know, Is there any software that depend on this Enabled
property? Otherwise I prefer to cut it out.

https://github.com/openbmc/x86-power-control/blob/master/power-control-x86/src/power_control.cpp#L2006
https://github.com/openbmc/phosphor-dbus-interfaces/blob/master/yaml/xyz/openbmc_project/Chassis/Control/NMISource.interface.yaml#L4


-- 
Best regards,
Andrei Kartashev