[PATCH u-boot v2019.04-aspeed-openbmc v2 5/6] config: ast2600: Disable SPL ymodem support

Klaus Heinrich Kiwi klaus at linux.vnet.ibm.com
Thu Jan 28 06:31:26 AEDT 2021



On 1/27/2021 4:00 AM, Joel Stanley wrote:
> This feature consumes 3656 bytes. Without it systems will need to load a
> new SPL over the UART with the AST2600's recovery feature if they flash
> a bad u-boot proper.
No objections here. Just a bit confusing since that in the introductory letter
you mention we *could* leave that enabled. So if that's not necessary, why
bundle that with this patchset (and not separate)?

> Signed-off-by: Joel Stanley <joel at jms.id.au>
> ---
>   configs/ast2600_openbmc_spl_emmc_defconfig | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/configs/ast2600_openbmc_spl_emmc_defconfig b/configs/ast2600_openbmc_spl_emmc_defconfig
> index 3f2de64e077d..c55a70c5c1c9 100644
> --- a/configs/ast2600_openbmc_spl_emmc_defconfig
> +++ b/configs/ast2600_openbmc_spl_emmc_defconfig
> @@ -55,7 +55,6 @@ CONFIG_SPL_DM_RESET=y
>   CONFIG_SPL_RAM_SUPPORT=y
>   CONFIG_SPL_RAM_DEVICE=y
>   CONFIG_SPL_WATCHDOG_SUPPORT=y
> -CONFIG_SPL_YMODEM_SUPPORT=y
>   CONFIG_HUSH_PARSER=y
>   # CONFIG_AUTO_COMPLETE is not set
>   CONFIG_SYS_PROMPT="ast# "

Reviewed-by: Klaus Heinrich Kiwi <klaus at linux.vnet.ibm.com>

-- 
Klaus Heinrich Kiwi <klaus at linux.vnet.ibm.com>


More information about the openbmc mailing list