[PATCH] ARM: dts: aspeed: Add device tree for Liwu2 BMC
Joel Stanley
joel at jms.id.au
Tue Feb 9 23:25:16 AEDT 2021
On Mon, 11 Jan 2021 at 09:45, Willie Thai <williethaitu at gmail.com> wrote:
>
> The Liwu2 is a server platform with an ASPEED AST2500 based BMC.
You need to have a signed-off-by in your commit message.
Please make sure you run ./scripts/checkpatch.pl on your patch before
sending it.
The patch looks okay; there are some minor issues to fix that I have
mentioned below. Apologies for the delay in reviewing it.
> ---
> arch/arm/boot/dts/Makefile | 1 +
> arch/arm/boot/dts/aspeed-bmc-compal-liwu2.dts | 320 ++++++++++++++++++++++++++
> 2 files changed, 321 insertions(+)
> create mode 100755 arch/arm/boot/dts/aspeed-bmc-compal-liwu2.dts
>
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index 5a14adc..16fc64d 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -1354,6 +1354,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \
> aspeed-bmc-arm-centriq2400-rep.dtb \
> aspeed-bmc-arm-stardragon4800-rep2.dtb \
> aspeed-bmc-bytedance-g220a.dtb \
> + aspeed-bmc-compal-liwu2.dts \
> aspeed-bmc-facebook-cmm.dtb \
> aspeed-bmc-facebook-minipack.dtb \
> aspeed-bmc-facebook-tiogapass.dtb \
> diff --git a/arch/arm/boot/dts/aspeed-bmc-compal-liwu2.dts b/arch/arm/boot/dts/aspeed-bmc-compal-liwu2.dts
> new file mode 100755
> index 0000000..a93af32
> --- /dev/null
> +++ b/arch/arm/boot/dts/aspeed-bmc-compal-liwu2.dts
> @@ -0,0 +1,320 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/dts-v1/;
> +
> +#include "aspeed-g5.dtsi"
> +#include <dt-bindings/gpio/aspeed-gpio.h>
> +
> +/ {
> + model = "AST2500 liwu2";
> + compatible = "aspeed,ast2500";
> +
> + aliases {
> + serial4 = &uart5;
> + };
> +
> + chosen {
> + stdout-path = &uart5;
> + bootargs = "console=tty0 console=ttyS4,115200 earlyprintk";
> + };
> +
> + memory at 80000000 {
> + reg = <0x80000000 0x20000000>;
> + };
> +
> + reserved-memory {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges;
> +
> + gfx_memory: framebuffer {
> + size = <0x01000000>;
> + alignment = <0x01000000>;
> + compatible = "shared-dma-pool";
> + reusable;
> + };
> + };
> +
> + iio-hwmon {
> + compatible = "iio-hwmon";
> + io-channels = <&adc 0>, <&adc 1>, <&adc 2>, <&adc 3>,
> + <&adc 4>, <&adc 5>, <&adc 6>, <&adc 7>,
> + <&adc 8>, <&adc 9>, <&adc 10>, <&adc 11>,
> + <&adc 12>, <&adc 13>, <&adc 14>, <&adc 15>;
> + };
> +
> + leds {
> + compatible = "gpio-leds";
> +
> + LED_FAN0_FAULT {
Node names have lower case.
> + label = "LED_FAN0_FAULT";
> + gpios = <&gpio ASPEED_GPIO(F, 4) GPIO_ACTIVE_LOW>;
> + };
> +
> + LED_FAN1_FAULT {
> + label = "LED_FAN1_FAULT";
> + gpios = <&gpio ASPEED_GPIO(F, 5) GPIO_ACTIVE_LOW>;
> + };
> +
> + LED_FAN2_FAULT {
> + label = "LED_FAN2_FAULT";
> + gpios = <&gpio ASPEED_GPIO(H, 2) GPIO_ACTIVE_LOW>;
> + };
> +
> + LED_FAN3_FAULT {
> + label = "LED_FAN3_FAULT";
> + gpios = <&gpio ASPEED_GPIO(H, 5) GPIO_ACTIVE_LOW>;
> + };
> +
> + LED_FAN4_FAULT {
> + label = "LED_FAN4_FAULT";
> + gpios = <&gpio ASPEED_GPIO(H, 6) GPIO_ACTIVE_LOW>;
> + };
> +
> + LED_FAN5_FAULT {
> + label = "LED_FAN5_FAULT";
> + gpios = <&gpio ASPEED_GPIO(H, 7) GPIO_ACTIVE_LOW>;
> + };
> +
> + FP_LED_STATUS_AMBER_N {
> + label = "FP_LED_STATUS_AMBER_N";
> + gpios = <&gpio ASPEED_GPIO(S, 5) GPIO_ACTIVE_LOW>;
> + };
> +
> + REAR_ID_LED_N {
> + label = "REAR_ID_LED_N";
> + gpios = <&gpio ASPEED_GPIO(S, 6) GPIO_ACTIVE_LOW>;
> + };
> + };
> +};
> +
> +&fmc {
> + status = "okay";
> + flash at 0 {
> + status = "okay";
> + m25p,fast-read;
> + label = "bmc";
> + spi-max-frequency = <50000000>;
> +#include "openbmc-flash-layout.dtsi"
> + };
> +};
> +
> +&spi1 {
> + status = "okay";
> + flash at 0 {
> + status = "okay";
> + m25p,fast-read;
> + label = "pnor";
> + spi-max-frequency = <100000000>;
> + };
> +};
> +
> +&spi2 {
> + status = "okay";
> +};
> +
> +&uart5 {
> + status = "okay";
> +};
> +
> +&mac0 {
> + status = "okay";
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_rgmii1_default &pinctrl_mdio1_default>;
> +};
> +
> +&mac1 {
> + status = "okay";
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_rgmii2_default &pinctrl_mdio2_default>;
> +};
> +
> +&adc {
> + status = "okay";
> +};
> +
> +&i2c0 {
> + status = "okay";
> +};
> +
> +&i2c1 {
> + status = "okay";
> +
> + eeprom at 54 {
> + compatible = "atmel,24c64";
> + reg = <0x54>;
> + pagesize = <32>;
> + };
> +};
> +
> +&i2c2 {
> + status = "okay";
> +};
> +
> +&i2c3 {
> + status = "okay";
> +
> + tmp75 at 48 {
> + compatible = "ti,tmp75";
> + reg = <0x48>;
> + };
> +
> + tmp75 at 4b {
> + compatible = "ti,tmp75";
> + reg = <0x4b>;
> + };
> +
> + tmp75 at 4c {
> + compatible = "ti,tmp75";
> + reg = <0x4c>;
> + };
> +
> + tmp75 at 4d {
> + compatible = "ti,tmp75";
> + reg = <0x4d>;
> + };
> +
> + vr-controller at 5a {
> + compatible = "ti,tps53679";
> + reg = <0x5a>;
> + };
> +
> + vr-controller at 5d {
> + compatible = "ti,tps53679";
> + reg = <0x5d>;
> + };
> +
> + vr-controller at 68 {
> + compatible = "ti,tps53679";
> + reg = <0x68>;
> + };
> +
> + vr-controller at 6a {
> + compatible = "ti,tps53679";
> + reg = <0x6a>;
> + };
> +
> + vr-controller at 6c {
> + compatible = "ti,tps53679";
> + reg = <0x6c>;
> + };
> +
> + vr-controller at 6e {
> + compatible = "ti,tps53679";
> + reg = <0x6e>;
> + };
> +
> +};
> +
> +&i2c4 {
> + status = "okay";
> +
> + eeprom at 51 {
> + compatible = "atmel,24c64";
The whitespace looks wrong here.
> + reg = <0x51>;
> + pagesize = <32>;
> + };
> +};
> +
> +&i2c5 {
> + status = "okay";
> +};
> +
> +&i2c6 {
> + status = "okay";
> +};
> +
> +&i2c7 {
> + status = "okay";
> +
> + power-supply at 58 {
> + compatible = "pmbus";
> + reg = <0x58>;
> + };
> +
> + power-supply at 59 {
> + compatible = "pmbus";
> + reg = <0x59>;
> + };
> +};
> +
> +
> +&sdmmc {
> + status = "okay";
> +};
> +
> +&sdhci0 {
> + status = "okay";
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_sd1_default>;
> +};
> +
> +&vhub {
> + status = "okay";
> +};
> +
> +&ehci1 {
> + status = "okay";
> +};
> +
> +&uhci {
> + status = "okay";
> +};
> +
> +&gfx {
> + status = "okay";
> + memory-region = <&gfx_memory>;
> +};
> +
> +&pwm_tacho {
> + status = "okay";
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_pwm0_default &pinctrl_pwm1_default
> + &pinctrl_pwm2_default &pinctrl_pwm3_default
> + &pinctrl_pwm4_default &pinctrl_pwm5_default
> + &pinctrl_pwm6_default &pinctrl_pwm7_default>;
> +
> + fan at 0 {
> + reg = <0x00>;
> + aspeed,fan-tach-ch = /bits/ 8 <0x00 0x01>;
> + };
> +
> + fan at 1 {
> + reg = <0x01>;
> + aspeed,fan-tach-ch = /bits/ 8 <0x02 0x03>;
> + };
> +
> + fan at 2 {
> + reg = <0x02>;
> + aspeed,fan-tach-ch = /bits/ 8 <0x04 0x05>;
> + };
> +
> + fan at 3 {
> + reg = <0x03>;
> + aspeed,fan-tach-ch = /bits/ 8 <0x06 0x07>;
> + };
> +
> + fan at 4 {
> + reg = <0x04>;
> + aspeed,fan-tach-ch = /bits/ 8 <0x08 0x09>;
> + };
> +
> + fan at 5 {
> + reg = <0x05>;
> + aspeed,fan-tach-ch = /bits/ 8 <0x0a 0x0b>;
> + };
> +
> + fan at 6 {
> + reg = <0x06>;
> + aspeed,fan-tach-ch = /bits/ 8 <0x0c 0x0d>;
> + };
> +
> + fan at 7 {
> + reg = <0x07>;
> + aspeed,fan-tach-ch = /bits/ 8 <0x0e 0x0f>;
> + };
> +
> +};
> +
> --
> 2.7.4
>
More information about the openbmc
mailing list