[PATCH v2 2/2] ARM: dts: aspeed: add device tree for YADRO VEGMAN BMC

Joel Stanley joel at jms.id.au
Tue Dec 7 09:39:41 AEDT 2021

On Sat, 20 Nov 2021 at 15:51, Andrei Kartashev <a.kartashev at yadro.com> wrote:
> >
> > Can we utilize
> > https://github.com/openbmc/docs/blob/master/designs/device-tree-gpio-naming.md
> >  to get some consistent naming across the GPIO’s on OpenBMC machines?
> >
> Some names here are standard for Intel daemons like x86-power-control,
> host-error-monitor, pfr-manager, IntrusionSensor and so on. Other lines
> just called same as in schematics to make it easy for our engineers to
> understand what does it refer to. BTW, most of the lines there not used
> by software and appeared just because dts files are supposed to be
> hardware description and thus we describe all we have in schematics.
> We can rename all this according to guide you mention, but are you
> sure, there is any sense to do so?
> Keep in mind, currently there are lot of dts files which also don't
> follow convention, so I believe, it is unnecessary work.

I have a strong preference for using the naming document. It provides
consistency, which makes it easier to review. I'm encouraging that for
any new dts.

If you think it makes the descriptions less useful for your platform
then that's a reasonable reason to not follow the convention.



More information about the openbmc mailing list