Turning off the D-Bus REST API by default

[Gunnar Mills]

On 8/12/2021 2:41 PM, Ed Tanous wrote:
> On Thu, Aug 12, 2021 at 1:32 PM i.kononenko <i.kononenko at yadro.com> wrote:
>>
>> Ali,
>>
>> On 12.08.2021 17:10, Ali Ahmed wrote:
>>
>>> After this commit to use phosphor-webui or D-Bus REST, you will need
>>> to set -Drest=enabled in your bbappend. Note: webui-vue uses Redfish
>>> and will not be impacted. Let me know if you have any concerns.
>>
>> As far I knew, the webui-vue uses REST API to retrieve the TPM status.
>> Please, look to the link below [1]
> 
> @gunnar @derick  isn't this against one of the primary design goals of
> webui-vue?  Was it intentionally merged?  It seems like having
> webui-vue rely on dbus-rest just keeps digging the hole deeper on this
> initial thing, which is getting dbus-rest disabled by default.
> 

I think when this was merged 2 years ago, when webui-vue was still very 
very young, the thinking was we will switch to Redfish when TPMenable is 
implemented in Redfish and there was value to having a working page. 
This does go against a core design goal of webui-vue.  I certainly would 
-1 any commit trying to add D-Bus REST API to webui-vue today. I think 
this is just a TODO that hasn't been implemented.
https://github.com/openbmc/webui-vue/blame/6dba4be6125c10210bafa030ac17737d3a9b28b8/src/store/modules/Operations/BootSettingsStore.js#L74

GET TrustedModuleRequiredToBoot is available today. The PATCH is in 
review here: https://gerrit.openbmc-project.xyz/c/openbmc/bmcweb/+/44044

We will push a commit to switch this to Redfish.