[PATCH linux dev-5.10] net: npcm: Remove superfluous logging

Joel Stanley joel at jms.id.au
Thu Apr 1 09:56:23 AEDT 2021


On Wed, 31 Mar 2021 at 22:38, William A. Kennington III <wak at google.com> wrote:
>
> Any queries of the ethernet interface will enter the settings functions.
> This causes dmesg to fill up with unnecessary log entries every time the
> phy information is queried.
>
> Signed-off-by: William A. Kennington III <wak at google.com>

Reviewed-by: Joel Stanley <joel at jms.id.au>

I've applied this and the other emc patch to dev-5.10.

Cheers,

Joel

> ---
>  drivers/net/ethernet/nuvoton/npcm7xx_emc.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/nuvoton/npcm7xx_emc.c b/drivers/net/ethernet/nuvoton/npcm7xx_emc.c
> index 3e9b8b68fc55..28aaee3e80ff 100644
> --- a/drivers/net/ethernet/nuvoton/npcm7xx_emc.c
> +++ b/drivers/net/ethernet/nuvoton/npcm7xx_emc.c
> @@ -1773,7 +1773,6 @@ static int npcm7xx_get_settings(struct net_device *netdev,
>         if (!phydev)
>                 return -ENODEV;
>
> -       dev_info(&ether->pdev->dev, "\n\nnpcm7xx_get_settings\n");
>         phy_ethtool_ksettings_get(phydev, cmd);
>
>         return 0;
> @@ -1789,7 +1788,6 @@ static int npcm7xx_set_settings(struct net_device *netdev,
>         if (!phydev)
>                 return -ENODEV;
>
> -       dev_info(&ether->pdev->dev, "\n\nnpcm7xx_set_settings\n");
>         ret =  phy_ethtool_ksettings_set(phydev, cmd);
>
>         return ret;
> --
> 2.31.0.291.g576ba9dcdaf-goog
>


More information about the openbmc mailing list