[PATCH linux dev-5.8 1/2] ARM: dts: Add 64MiB OpenBMC flash layout

[Joel Stanley]

On Mon, 28 Sep 2020 at 06:43, John Wang <wangzhiqiang.bj at bytedance.com> wrote:
>
> This is an alternate layout used by OpenBMC systems
>
> The division of space is as follows:
>
>  u-boot + env: 0.5MB
>  kernel/FIT: 5MB
>  rofs: 42.5MB
>  rwfs: 16MB
>
> Signed-off-by: John Wang <wangzhiqiang.bj at bytedance.com>

Looks good to me.

Are you confident your kernel and u-boot will fit as you add features?

Do we have a location in the OpenBMC documentation that lists the
various flash layouts? If not, it would be good to add something at
github.com/openbmc/docs

> ---
>  .../arm/boot/dts/openbmc-flash-layout-64.dtsi | 32 +++++++++++++++++++
>  1 file changed, 32 insertions(+)
>  create mode 100644 arch/arm/boot/dts/openbmc-flash-layout-64.dtsi
>
> diff --git a/arch/arm/boot/dts/openbmc-flash-layout-64.dtsi b/arch/arm/boot/dts/openbmc-flash-layout-64.dtsi
> new file mode 100644
> index 000000000000..18c8047c1d0c
> --- /dev/null
> +++ b/arch/arm/boot/dts/openbmc-flash-layout-64.dtsi
> @@ -0,0 +1,32 @@
> +// SPDX-License-Identifier: GPL-2.0+

Add a copyright notice referring to the copyright holder and the year.

> +
> +partitions {
> +       compatible = "fixed-partitions";
> +       #address-cells = <1>;
> +       #size-cells = <1>;
> +
> +       u-boot at 0 {
> +               reg = <0x0 0x60000>; // 384KB
> +               label = "u-boot";
> +       };
> +
> +       u-boot-env at e0000 {
> +               reg = <0x60000 0x20000>; // 128KB
> +               label = "u-boot-env";
> +       };
> +
> +       kernel at 100000 {
> +               reg = <0x80000 0x500000>; // 5MB
> +               label = "kernel";
> +       };
> +
> +       rofs at a00000 {
> +               reg = <0x580000 0x2a80000>; // 42.5MB
> +               label = "rofs";
> +       };
> +
> +       rwfs at 6000000 {
> +               reg = <0x3000000 0x1000000>; // 16MB
> +               label = "rwfs";
> +       };
> +};
> --
> 2.25.1
>