Quanta requests to create a repo in OpenBMC github

[Benjamin Fair]

On Fri, 18 Sep 2020 at 08:50, Patrick Venture <venture at google.com> wrote:
>
> On Fri, Sep 18, 2020 at 1:06 AM Andrei Kartashev <a.kartashev at yadro.com> wrote:
> >
> >
> > > This daemon is intended to be used in combination with
> > > phosphor-pid-control. You define a configuration file with two
> > > sections: sensors and zones.
> > >
> > > Sensors have a D-Bus path to read from along with a target
> > > temperature
> > > and some other parameters. The daemon subtracks the current
> > > temperature from the target temperature to get the "margin". A
> > > smaller
> > > margin means the temperature is closer to the limit.
> > >
> > > Zones group sensors together and look for the worst (lowest) margin
> > > value within that group. This value is then exported for use in
> > > phosphor-pid-control.
> >
> >
> > I wonder, isn't phosphor-pid-control do the same by its own? How does
> > it works inside pid-control daemon, when you set several thermal
> > sensors for one Zone an set setpoint for each of them?
>
> Not sure what your question is, but yes, the pid-control daemon can
> host its own margin sensor values that are populated externally,
> however this is only supported via the json configuration at present.

It also doesn't support mixing margin sensors and absolute sensors.

Doing this margin calculation seems separate enough from the core
functions of phosphor-pid-control that I think splitting it out is the
best approach, but I do also see the argument for merging the
functionality into phosphor-pid-control.

>
> >
> >
> > --
> > Best regards,
> > Andrei Kartashev
> >
> >