[PATCH v1 1/4] dt-binding: watchdog: add restart priority documentation

[Tomer Maimon]

Thank you for the clarification.

I will remove the priority patch, and send a new patch set after receiving
comments for the boot status patch.

Tomer

On Sun, 1 Mar 2020 at 17:46, Guenter Roeck <linux at roeck-us.net> wrote:

> On 3/1/20 7:36 AM, Tomer Maimon wrote:
> >
> >
> > On Sun, 1 Mar 2020 at 12:06, Guenter Roeck <linux at roeck-us.net <mailto:
> linux at roeck-us.net>> wrote:
> >
> >     On 3/1/20 1:40 AM, Tomer Maimon wrote:
> >     > Add device tree restart priority documentation.
> >     >
> >
> >     I think this warrants an explanation _why_ this is needed.
> >     What is the use case ? Not just theory, please.
> >
> >
> > In the NPCM750 there is two initiated restarts:
> >
> >   * Software reset
> >   * WD reset
> >
> > the Software restart found at NPCM reset driver
> > https://github.com/torvalds/linux/blob/master/drivers/reset/reset-npcm.c
> >
> > In NPCM WD driver the restart is configure as well, I will like to add
> the priority so the user will have maximum flexibility if he using both
> restarts
> >
>
> This is not the intended use case for restart priority. It is not
> intended to be user configurable. The idea is that the more thorough
> restart gets higher priority. This is implied by the restart method,
> not by user preferences.
>
> Also, the idea behind supporting multiple means to reset the system
> is to be able to support multiple means to restart, some of which
> may not always be available. In that situation, the priority means,
> and is supposed to mean, "pick the best restart method available".
> Again, that is determined by system design, and not supposed to
> be configurable by the user.
>
> On top of that, a watchdog driver based reset is almost always
> a reset of last resort, to be chosen only if nothing else is available
> in a given system. The existence of the reset driver confirms that
> this is not different for this driver/chip.
>
> Guenter
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ozlabs.org/pipermail/openbmc/attachments/20200301/3bb539e7/attachment.htm>