phosphor-ipmi-flash state recovery

[Patrick Venture]

On Tue, Jun 2, 2020 at 5:20 PM Brandon Kim <brandonkim at google.com> wrote:
>
> Created https://github.com/openbmc/phosphor-ipmi-flash/issues/7 to track this issue.
>
> Thanks,
> Brandon

Thanks. I had some time while working on cleaning up things for a
different build environment, and dropped in an expiration method
(sorry forgot to reply to this email when I did it).

>
> On Tue, May 26, 2020 at 7:26 PM Patrick Venture <venture at google.com> wrote:
>>
>> On Tue, May 26, 2020 at 3:14 PM Patrick Voelker
>> <Patrick_Voelker at phoenix.com> wrote:
>> >
>> >
>> >
>> > > > Internally, it looks like I need to get to abortProcess() but to do that I need
>> > > to close the current session but I don’t have a way to obtain the sessionID
>> > > after the fact.  Also the stale session doesn’t seem to expire (as mentioned
>> > > in the readme.md) and I can’t find the support for that in the code.
>> > >
>> > > https://github.com/openbmc/phosphor-ipmi-
>> > > flash/blob/master/bmc/firmware_handler.cpp#L95
>> > >
>> > > You should be able to just delete any of the blob Id paths, such as
>> > > the active blob path, and that should trigger what you want.
>> >
>> > As coded, that only works to abort when in in the verificationPending and updatePending states.  That won't work if it's stuck in the middle of an aborted transfer with a session that's still open.
>>
>> Right - because handlers don't control sessions, those are owned by
>> the blob manager that's routing the commands. - then we'll need a
>> patch to handle expiration, per the email chain - Sorry, I
>> misunderstood the circumstance.