Re: [PATCH linux dev-5.4 1/2] usb: gadget: aspeed: add ast2600 vhub support

[Andrew Jeffery]

> > > +
> > > +#ifdef CONFIG_MACH_ASPEED_G6
> > 
> > No, this prevents building a kernel supporting multiple AST generations. Please
> > describe the differences in a platform data struct attached to struct of_device_id.
> 
> Got it. I took "#ifdef" approach just because it involves little
> changes. Let me move to of_device_id direction then.

Thanks.

> 
> > Also, what's the plan for upstreaming these changes? It's okay to send them for
> > inclusion in the openbmc tree if you're wanting them to bake there for some
> > more widespread testing, but it's not clear what the intent is.
> > 
> > Cheers,
> > 
> > Andrew
> 
> My major goal was to get more testing and early feedback. Given we've
> decided to go with of_device_id approach, let's ignore the patchs then.

No worries, in the future just let us know in the cover letter :)

Andrew